1615335 - TRR: Use SimpleHttpChannel off main thread

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P1)

Description

[Kershaw Chang [:kershaw]]

We want to use the simple http channel implemented in bug 1613873 off main thread.
Things included in this bug are:

1. Run TRR::SendHTTPRequest off main thread.
2. Don't read prefs at these places.
3. Remove some main thread assertions.

Comment 1

[Kershaw Chang [:kershaw]]

Hi Valentin,
Do you have time to work on this bug?
If not, I can try to take this one.

Comment 2

[Valentin Gosu [:valentin]]

I can take this one. I'll start working on it around the middle of next week.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1615335 - WIP

Comment 4

[Kershaw Chang [:kershaw]]

Steal this from Valentin.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1615335 - Use SimpleHttpChannel to fetch TRR data

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1615335 - Add TRR Background to ThreadAllows.txt

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1dc4f624f16
Use SimpleHttpChannel to fetch TRR data r=valentin
https://hg.mozilla.org/integration/autoland/rev/521b0f9e84a3
Add TRR Background to ThreadAllows.txt r=valentin,andi

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a1dc4f624f16
https://hg.mozilla.org/mozilla-central/rev/521b0f9e84a3

Comment 9

[Julien Cristau [:jcristau]]

I asked sheriffs to back this out due to bug 1619822.

Comment 10

[Natalia Csoregi [:nataliaCs]]

backout: https://hg.mozilla.org/mozilla-central/rev/c58fa28bc07ed81ecb786f2dad4ad54a5a22e055

Comment 11

[Kershaw Chang [:kershaw]]

I think I've figured out the problem.
Basically, the problem is that the TRR background channel is accessed by JS at here.
I think we should avoid this channel being accessed by any JS code.

Comment 12

[Kershaw Chang [:kershaw]]

Attachment: Bug 1615335 - Don't let TRR background channel to be accessed by ProxyChannelFilter

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c2e9174b14
Don't let TRR background channel to be accessed by ProxyChannelFilter r=valentin
https://hg.mozilla.org/integration/autoland/rev/9aec65b62bbf
Use SimpleHttpChannel to fetch TRR data r=valentin
https://hg.mozilla.org/integration/autoland/rev/3950f827b14b
Add TRR Background to ThreadAllows.txt r=valentin,andi

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/63c2e9174b14
https://hg.mozilla.org/mozilla-central/rev/9aec65b62bbf
https://hg.mozilla.org/mozilla-central/rev/3950f827b14b