Closed
Bug 1615354
Opened 4 years ago
Closed 4 years ago
Rename FinalizationGroup 'holdings' field to 'heldValue' in line with the spec
Categories
(Core :: JavaScript: GC, task, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
Bug 1615354 - Rename FinalizationGroup 'holdings' field to 'heldValue' in line with the spec r?sfink
47 bytes,
text/x-phabricator-request
|
Details | Review |
There have been a few things renamed in the spec recently. I don't think it makes sense to rename 'target' to 'weakRefTarget' because that change is mainly to disambiguate this field in the spec relative to completion value's target field. In the code 'target' makes sense in context for WeakRef and FinalizationGroup.
However, 'heldValue' is definitely a better name than 'holdings' so we should rename this.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26bdfb4148ed Rename FinalizationGroup 'holdings' field to 'heldValue' in line with the spec r=sfink
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•