1615394 - Add color management support to BMP decoder

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

BMPs can include an ICC profile. The v5 header is described here:

https://docs.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-bitmapv5header

Fields such as bV5CSType, bV5ProfileData, bV5ProfileSize, etc are all relevant. Currently we just assume BMPs are always sRGB. Presumably this is mostly relevant we were are pasting an image from the clipboard and/or reencoding it into a different format -- being able to get the ICC data would be very useful indeed.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1615394 - Add color management support to the BMP decoder.

This patch adds support for color management in BMPs added in
BITMAPV4HEADER and BITMAPV5HEADER. While display of BMPs is relatively
rare this comes in handy when interacting with the Windows clipboard.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/388ac5609ceb
Add color management support to the BMP decoder. r=tnikkel

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 388ac5609ceb (bug 1615394) for MinGW build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291410550&repo=autoland&lineNumber=73463

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=388ac5609ceb8597edbce4a07073be160e6dd60e

Backout:
https://hg.mozilla.org/integration/autoland/rev/adda3cc684142559d46ca3c4f427a5bc270cb892

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e5d74671e98
Add color management support to the BMP decoder. r=tnikkel

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4e5d74671e98