1615434 - MaxMemoryInitialPages is incorrect

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Lars T Hansen [:lth]]

The spec says that the max number if initial pages is 32K, but our code uses 16K. This does not seem to have been a problem in practice, which is perhaps a useful data point in connection with the discussion about MaxInitial / MaxMaximum memory length: code does not in practice set the heap initial at very large values.

Comment 1

[Ryan Hunt [:rhunt]]

I'm taking a look at this.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1615434 - Increase maximum initial memory size to 2GiB. r?lth

The spec no longer has an initial memory size limit, so we should allow up to
the limit imposed upon us by ArrayBuffer.

Depends on D80139

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1615434 - Increase maximum initial memory size to 2GiB. r?lth

The spec no longer has an initial memory size limit, so we should allow up to
the limit imposed upon us by ArrayBuffer.

Depends on D80750

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/068ffb754356
Increase maximum initial memory size to 2GiB. r=lth

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for SM bustages on limits.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1764e49f51f9d37c719427c10e959b31040ee023
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307475273&repo=autoland&lineNumber=42256

Comment 6

[Ryan Hunt [:rhunt]]

See bug 1642940 for info on the error's cause.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd6573a5176d
Increase maximum initial memory size to 2GiB. r=lth

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bd6573a5176d