1615498 - After navigating away from cnn.com, GeckoView keeps receiving sensor events and wasting battery, and becomes unquittable

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Markus Stange [:mstange]]

This one's a doozy.

Steps to reproduce:

1. Open Firefox Preview Nightly or GeckoView-example.
2. Navigate to cnn.com and wait for it to load.
3. In the same tab, navigate to google.com.
4. Press the device home button to leave the app.
5. Attempt to shut down the app via the close button in Android's app switcher. The app is now gone from the app switcher.
6. Switch off the screen with the power button.

Expected results:
The app should have shut down.

Actual results:
You can still see the browser on about:debugging. And here's a profile: https://perfht.ml/31QuWrY
We're waking up the CPU every 5ms to send NotifySensorChange events to our content processes! Even while the screen is off! What!

Comment 1

[Eugen Sawin [:esawin]]

cnn.com has THEOplayer as one of its dependencies, which iterates through all the sensor devices and attaches listeners.

When the session is set inactive, we suspend the window and remove all event listeners properly.

However, we miss to detach the sensor listeners when closing nsGlobalWindowInner on navigation.
We have to ensure that all device event listeners are removed when closing the window.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1615498 - [1.0] Remove all window event listener before disconnecting the manager.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d805e81bf04e
[1.0] Remove all window event listener before disconnecting the manager. r=smaug

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d805e81bf04e