Closed Bug 161556 Opened 22 years ago Closed 22 years ago

Arabic bitmap fonts are printed too small

Categories

(Core Graveyard :: Printing: Xprint, defect)

Sun
Solaris
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

()

Details

(Keywords: fixedOEM)

Attachments

(1 file, 1 obsolete file)

[Another incarnation of the bitmap-font-prints-too-small]
(2002-08-04-08-trunk on Solaris/SPARC printing with Xprint module through
mozdev.org trunk Xprt build:)
Arabic bitmap fonts are printed too small for the given example URL; source font
is '-arabic-newspaper-medium-r-normal--56-435-93-93-p-240-iso10646-1'
Taking myself...
Assignee: katakai → Roland.Mainz
Summary: Arabic bitmap fonts are printed too small → Arabic bitmap fonts are printed too small
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
Attached patch Patch for 2002-08-04-08-trunk (obsolete) — Splinter Review
I had this feeling while hacking bug 140673 ("Some Arabic/Hebrew bitmap fonts
printed way too small with Xprint") that keeping the scaling factor |1.0|
around is not a good idea.
The "feeling" was correct - and results in this bug.

The fix is to completely avoid scaling factor |1.0| - IMHO we do not need it.
Comment on attachment 94381 [details] [diff] [review]
Same patch as previous one, only with "gdiff -u20" instead of "gdiff -u" (for review)

This sounds like the right thing to do.
Attachment #94381 - Flags: review+
Comment on attachment 94381 [details] [diff] [review]
Same patch as previous one, only with "gdiff -u20" instead of "gdiff -u" (for review)

r=smontagu
Comment on attachment 94381 [details] [diff] [review]
Same patch as previous one, only with "gdiff -u20" instead of "gdiff -u" (for review)

sr=darin
Attachment #94381 - Flags: superreview+
Fix checked-in
(http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&branch=HEAD&cvsroot=/cvsroot&date=explicit&mindate=1028763480&maxdate=1028763780&who=smontagu%25netscape.com),
marking bug as FIXED...
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: branchOEM
Blocks: xprint_machv
Requested a= for 1.0.1-branch...
Keywords: mozilla1.0.1
Marked it branchOEM+ for check in to the OEM branch.  This is per Jim Dunn's
email  to Ron and Roland, and based on our i18n engineer (Prabhat Hegde)'s
opinion on the need of the fix.  Since Roland is not around this week (as I have
heard), Masaki:  Can you check this in to the OEM branch please?  Thanks.  Let
me know if you can't, I'll try to do so tomorrow.
Whiteboard: branchOEM → branchOEM+
checked in to OEM branch
Whiteboard: branchOEM+ → branchOEM+,fixedOEM
Thank you very much, Masaki.  Margaret
Whiteboard: branchOEM+,fixedOEM → fixedOEM
Blocks: 168057
Nominating for 1.0.2-branch...
Keywords: mozilla1.0.2
Comment on attachment 94381 [details] [diff] [review]
Same patch as previous one, only with "gdiff -u20" instead of "gdiff -u" (for review)

a=rjesup@wgate.com for 1.0 branch; change mozilla1.0.2+ to fixed1.0.2 when
checked in
Attachment #94381 - Flags: approval+
Checked in to 1.0 branch
Keywords: fixedOEM
Whiteboard: fixedOEM
Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2 
Verified on branch. 
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: