1615560 - Expose default search engine pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

The WNPanel message requires access to the default search engine name. We need to expose this value.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1615560 - Expose default search engine name to WNPanel messages

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c92802939c1
Expose default search engine name to WNPanel messages r=fluent-reviewers,k88hudson,Pike

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4c92802939c1

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the default engine name is successfully displayed in the "WHATS_NEW_AWESOMEBAR_74" message from the WNPanel.
I have verified the following also:

• if the default engine is changed, the name from the message is changed accordingly;
• the related telemetry pings are displayed in the "Browser Console".

Verified using the latest Firefox Nightly (75.0a1 Build ID - 20200216210001) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.

Comment 5

[Andrei Oprea [:andreio]]

Comment on attachment 9126692 [details]
Bug 1615560 - Expose default search engine name to WNPanel messages

Beta/Release Uplift Approval Request

• User impact if declined: The What's New Panel messages that highlight new features cannot be personalized to the user's profile
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change verified by QA.
  Strings can be delivered off train.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9126692 [details]
Bug 1615560 - Expose default search engine name to WNPanel messages

Low risk, has tests and was verified by QA, uplift approved for 74.0b6, thanks.

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/67779866cf3a

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the default engine name is successfully displayed in the "WHATS_NEW_AWESOMEBAR_74" message from the WNPanel.
I have verified the following also:

• if the default engine is changed, the name from the message is changed accordingly;
• the related telemetry pings are displayed in the "Browser Console".

Verified using the latest Firefox Beta (74.0b7 Build ID - 20200221211950) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.