1615630 - Error handling in PaymentRequestManager::RespondPayment doesn't make sense

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

In the IPCPaymentActionResponse::TIPCPaymentShowActionResponse case, the code does:

      aRequest->RespondShowPayment(response.methodName(), responseData,
                                   response.payerName(), response.payerEmail(),
                                   response.payerPhone(), rejectedReason);
      if (rejectedReason.Failed()) {
        NotifyRequestDone(aRequest);
      }

But RespondShowPayment consumes the failure on rejectedReason; after that call that reason never tests true for Failed(). So that NotifyRequestDone call is never reached. Should it be, if rejectedReason was a failure before the call to RespondShowPayment?

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1615630 - Call PaymentRequestManager::NotifyRequestDone() when PaymentShowActionResponse.status() is not PAYMENT_ACCEPTED before calling PaymentRequest::RespondShowPayment

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85cd7053db6d
Call PaymentRequestManager::NotifyRequestDone() when PaymentShowActionResponse.status() is not PAYMENT_ACCEPTED before calling PaymentRequest::RespondShowPayment r=baku,alchen

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/85cd7053db6d