1615633 - WR_FEATURE_TEXTURE_RECT shader compilation fails on GLES

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jamie Nicol [:jnicol]]

If I run webrender with ShaderPrecacheFlags::FULL_COMPILE it tries to compile all shaders, and fails when compiling ones using GL_TEXTURE_RECTANGLE. This is not supported on GLES. We should mark it as such here so that we don't attempt to compile it.

Comment 1

[Jamie Nicol [:jnicol]]

For posterity, this is the error we get:

ERROR 2020-02-18T10:07:08Z: webrender::device::gl: Failed to compile shader: brush_image
0:273(9): error: illegal use of reserved word `sampler2DRect'
0:273(9): error: syntax error, unexpected ERROR_TOK

ERROR 2020-02-18T10:07:08Z: webrender::device::gl: | #elif defined WR_FEATURE_TEXTURE_RECT
ERROR 2020-02-18T10:07:08Z: webrender::device::gl: > uniform sampler2DRect sColor0;
ERROR 2020-02-18T10:07:08Z: webrender::device::gl: | uniform sampler2DRect sColor1;

Comment 2

[Jamie Nicol [:jnicol]]

Attachment: Bug 1615633 - Do not compile WR_FEATURE_TEXTURE_RECT shaders on GLES. r?gw

It is not supported, so running wrench with the --precache flag
fails to compile the texture rect shader variants. Without the
precache flag, webrender does not attempt to use such shaders, so this
is not an issue in the wild.

Comment 3

[Glenn Watson [:gw]]

Should we close this? Looks like the patch is accepted but not landed?

Comment 4

[Jamie Nicol [:jnicol]]

This was fixed as part of bug 1615633