1615640 - Remove references to panel.switchToTarget in toolbox::switchToTarget

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

As discussed with :yzen, we still have some code in toolbox::switchToTarget that call "switchToTarget" on individual panels. However this is not implemented by any panel and should be normally handled via the target list.

This code should be removed
https://searchfox.org/mozilla-central/rev/174f1195ec740e8f17223b48018f7e14e6d4e40e/devtools/client/framework/toolbox.js#522-529

    await Promise.all(
      [...this._toolPanels.values()].map(panel => {
        if (panel.switchToTarget) {
          return panel.switchToTarget(newTarget);
        }
        return Promise.resolve();
      })
    );

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1615640 - Remove references to panel.switchToTarget in toolbox::switchToTarget

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22d3cd05bacf
Remove references to panel.switchToTarget in toolbox::switchToTarget r=ochameau

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/22d3cd05bacf