1615851 - Crash in ImageBitmap::ToCloneData when running webgl/sdk/tests/conformance2/textures/image_bitmap_from_video/tex-2d-r32f-red-float.html?webglVersion=2&quiet=0&quick=1

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1615851 - layer::Image::GetAsSourceSurface is fallible.

This fixes a crash, where we expected it to be infallible.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb59957df144
layer::Image::GetAsSourceSurface is fallible. r=lsalzman

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fb59957df144

Comment 4

[Chris Peterson [:cpeterson]]

Jeff, is GetAsSourceSurface() always fallible? Here are some other calls to GetAsSourceSurface() that do not verify the returned surface (in release builds). Should they all be changed to verify surface like you did in ImageBitmap::ToCloneData()?

Also, should this fix be uplifted to 74 Beta?

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageBitmap.cpp#1371-1372

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageBitmap.cpp#1404-1405

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageBitmapRenderingContext.cpp#85-87

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageBitmapRenderingContext.cpp#123-124

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageBitmapRenderingContext.cpp#174-175

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/dom/canvas/ImageUtils.cpp#123-126

https://searchfox.org/mozilla-central/rev/cc0f9906505d0ffa0d3a29a80142379e21cb5fb2/gfx/layers/client/ImageClient.cpp#130-133

Comment 5

[Kelsey Gilbert [:jgilbert]]

It's hard to tell but we should at least be asserting at all these points.
I'm not worried about uplifting the fix here to Beta, given that the only crashes are pretty much just me. :)
I'll shave this yak on Tuesday. Thanks for checking up on this!