Closed Bug 1615853 Opened 2 years ago Closed 2 years ago

Searching for "encoding" points to a setting that doesn't exist anymore

Categories

(Firefox :: Preferences, defect, P1)

73 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- wontfix
firefox74 --- verified
firefox75 --- verified

People

(Reporter: gingerbread_man, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0
20200215095617

STR:

  1. about:preferences
  2. Type encoding in the Find box.

AR:
Search result highlights the Advanced… button in the Fonts and Colors category. There's no such setting there anymore, because it was removed in bug 1551276.

ER:
No search results.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Keywords: regression
Regressed by: 1551276
Priority: -- → P1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/935977d665a9
do not include fallback language strings as search strings for advanced fonts button, r=johannh
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2bb94accccc0
do not include fallback language strings as search strings for advanced fonts button, r=johannh
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0
20200220093508

No more search results for encoding.

Status: RESOLVED → VERIFIED

Gijs, this bug is marked as P1, should the fix be uplifted to beta? Thanks

Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9127111 [details]
Bug 1615853 - do not include fallback language strings as search strings for advanced fonts button, r?johannh

Beta/Release Uplift Approval Request

  • User impact if declined: confusing search results in the preferences
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Straightforward small patch to avoid having some strings listed as search hits for a button when they shouldn't be
  • String changes made/needed: nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9127111 - Flags: approval-mozilla-beta?

Comment on attachment 9127111 [details]
Bug 1615853 - do not include fallback language strings as search strings for advanced fonts button, r?johannh

P1n, low risk with tests, uplift approved for 74.0b7, thanks.

Attachment #9127111 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the initial issue using Release version 73.0.1 using Windows 10.
Verified - Fixed in latest Beta 74.0b7 (Build id: 20200221211950) using Windows 10, Mac OS 10.14 and Ubuntu 18.04.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.