1615853 - Searching for "encoding" points to a setting that doesn't exist anymore

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0
20200215095617

STR:

1. about:preferences
2. Type encoding in the Find box.

AR:
Search result highlights the Advanced… button in the Fonts and Colors category. There's no such setting there anymore, because it was removed in bug 1551276.

ER:
No search results.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1615853 - do not include fallback language strings as search strings for advanced fonts button, r?johannh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/935977d665a9
do not include fallback language strings as search strings for advanced fonts button, r=johannh

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 935977d665a9 (bug 1615853) for causing browser_search_subdialogs_within_preferences_5.js to permafail
https://hg.mozilla.org/integration/autoland/rev/24a0cd3971602d43fcb416cbfa2de99168e0eb49

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=289543953&searchStr=OS%2CX%2C10.14%2CShippable%2Copt%2CMochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s-6%2CM%28bc6%29&revision=935977d665a92f355092321226060d361b04a7cb

Comment 4

[:Gijs (he/him)]

lol

https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js#21

  await evaluateSearchResults("Text Encoding", "fontsGroup");

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bb94accccc0
do not include fallback language strings as search strings for advanced fonts button, r=johannh

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2bb94accccc0

Comment 7

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0
20200220093508

No more search results for encoding.

Comment 8

[Pascal Chevrel:pascalc]

Gijs, this bug is marked as P1, should the fix be uplifted to beta? Thanks

Comment 9

[:Gijs (he/him)]

Comment on attachment 9127111 [details]
Bug 1615853 - do not include fallback language strings as search strings for advanced fonts button, r?johannh

Beta/Release Uplift Approval Request

• User impact if declined: confusing search results in the preferences
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward small patch to avoid having some strings listed as search hits for a button when they shouldn't be
• String changes made/needed: nope

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9127111 [details]
Bug 1615853 - do not include fallback language strings as search strings for advanced fonts button, r?johannh

P1n, low risk with tests, uplift approved for 74.0b7, thanks.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/debc5d462cab

Comment 12

[Alin Ilea, Desktop QA]

Reproduced the initial issue using Release version 73.0.1 using Windows 10.
Verified - Fixed in latest Beta 74.0b7 (Build id: 20200221211950) using Windows 10, Mac OS 10.14 and Ubuntu 18.04.