Closed Bug 1615911 Opened 5 years ago Closed 5 years ago

Port Bug 645428 "sessionstore-windows-restored" is not sent for empty sessions to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey 2.72
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.2)

Attachments

(1 file, 3 obsolete files)

Summary says it all.

I was unable to reproduce the scenario but understand how this can happen. Patch should break nothing and makes the code a bit more compatible with later Gecko/Fx.
Test not ported.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: none visible but aligns sessionstore code
Testing completed (on m-c, etc.): 2.53.1
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: --

Attachment #9126978 - Flags: review?(iann_bugzilla)
Attachment #9126978 - Flags: approval-comm-release?
Attachment #9126978 - Flags: approval-comm-esr60?
Attached patch Ian's version (obsolete) — Splinter Review
Attachment #9126979 - Flags: feedback?(frgrahl)
Blocks: SMSSUpdate
Attached patch Port changes v1.1 (obsolete) — Splinter Review

Merged version of the two other patches

Attachment #9126978 - Attachment is obsolete: true
Attachment #9126979 - Attachment is obsolete: true
Attachment #9126978 - Flags: review?(iann_bugzilla)
Attachment #9126978 - Flags: approval-comm-release?
Attachment #9126978 - Flags: approval-comm-esr60?
Attachment #9126979 - Flags: feedback?(frgrahl)
Attachment #9127070 - Flags: review?(frgrahl)
Attachment #9127070 - Flags: approval-comm-release?
Attachment #9127070 - Flags: approval-comm-esr60?

Fixed checkin comment and added timestamp to HG Header

Attachment #9127070 - Attachment is obsolete: true
Attachment #9127070 - Flags: review?(frgrahl)
Attachment #9127070 - Flags: approval-comm-release?
Attachment #9127070 - Flags: approval-comm-esr60?
Attachment #9127108 - Flags: review?(frgrahl)
Attachment #9127108 - Flags: approval-comm-release?
Attachment #9127108 - Flags: approval-comm-esr60?
Assignee: frgrahl → iann_bugzilla
Comment on attachment 9127108 [details] [diff] [review] Port changes v1.1a LGTM No wonder 2 people and more or less the same patch minus tests :)
Attachment #9127108 - Flags: review?(frgrahl)
Attachment #9127108 - Flags: review+
Attachment #9127108 - Flags: approval-comm-release?
Attachment #9127108 - Flags: approval-comm-release+
Attachment #9127108 - Flags: approval-comm-esr60?
Attachment #9127108 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/be2e2e5d1813
Port |Bug 645428 - "sessionstore-windows-restored" is not sent for empty sessions| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: