1615921 - Advance the toolkit.shutdown.lateWriteChecksStage pref to before xpcom-shutdown-threads

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Alex Thayer [:alexical] (she/her)]

We should be able to move this value forward at this point. It's not clear that anything will show up past this point, so it would be good to confirm that or observe in the wild that there is nothing.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1615921 - Move lateWriteChecks earlier in shutdown r?froydnj

This moves the late write checking forward to before xpcom-shutdown-threads
in Nightly, and it turns it on for after the last cycle collection on
beta/release.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1615921 - Suspend late write checks in Windows vprintf_stderr r?froydnj

Depends on D63215

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1615921 - Skip writing to pdf file if shutting down r?jwatt

We are intending to advance the toolkit.shutdown.lateWriteChecksStage
pref, to collect information (and crash on DEBUG) about writes which
happen during and after the xpcom-shutdown-threads notification. This
is producing failures in the PrintTargetPDF.cpp destructor because
we end up calling write_func and writing to (I presume) the target
PDF. This feels like something we can just skip, so that's the
review request I am sending, but please let me know if it's critical
that we write to this file during shutdown.

Depends on D63216

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c7f36f4ae89
Suspend late write checks in Windows vprintf_stderr r=froydnj

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8c7f36f4ae89

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3817b1074f5c
Move lateWriteChecks earlier in shutdown r=froydnj
https://hg.mozilla.org/integration/autoland/rev/edf46a901a6b
Skip writing to pdf file if shutting down r=jwatt

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3817b1074f5c
https://hg.mozilla.org/mozilla-central/rev/edf46a901a6b