1615973 - "Invoke getter" prompt in console sticks around too long

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Marijn Haverbeke]

Thank you for helping make Firefox better. If you are reporting a defect, please complete the following:

What were you doing?

Please tell us what site you were on, and what steps led to the error you are reporting

1. In the console, create an object with a getter:

   let x = {get y() { return "foo" }}

2. Still from the console, access a property of the getter property:

   x.y.length

3. On the second period character, the "Invoke getter x.y..." prompt will pop up. But when you continue typing it remains open. Even after you press Enter, the prompt is still there.

What happened?

There's a stray prompt popup visible, cluttering up the devtools, after it has become irrelevant.

What should have happened?

The popup should hide as soon as possible. Preferably after my cursor is no longer in a property of the relevant properly, but at the very least when I've completed my console input with Enter.

(This is somewhat similar to 1534706, but not the same issue.)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Let's use this bug to hide the invoke getter popup when the input gets evaluated, since it looks quite bad.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1615973 - Hide invoke getter popup when evaluating expression. r=Honza.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/813b494a8388
Hide invoke getter popup when evaluating expression. r=Honza.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/813b494a8388