1616063 - Popup blocking is broken

Status: RESOLVED INVALID

(GeckoView :: General, defect, P1)

Description

[Manuel Martin]

+++ This bug was initially created as a clone of Bug #1610338 +++

Steps to reproduce:

• Enable e10
• Go to http://www.popuptest.com/ and run any test
• Once a popup is shown navigate to another site

This happens both in Firefox Reality and Fenix including the current Fennec Nightly.

Actual results:

Scrolling doesn't work anymore

Expected results:

Scrolling should work

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is working fine in Fenix. At one point, FxR was not resolving the GeckoResult returned from onPopupPrompt(). Is that still the case? If so, can you try denying it or something and see if that helps?

Comment 2

[Manuel Martin]

I can reproduce this in Fenix master too. I've tried to always complete the result confirming the prompt and I get the same result. Disabling e10s solves the issue.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

OK, things are even worse on desktop. The following STR work for me:

1. Navigate to http://popuptest.com/popuptest4.html
2. Hover over the "Mouseover Popup" link
3. Accept at least one of the popup windows in the doorhanger
4. Observe that you can't edit the location bar in the new popup window.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Andrew, this seems kinda DOM-like? Could we get an assignee? This is blocking FxR release, but also occurs on Fenix and desktop.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Isn't that the UI Firefox has had for popups for ages. Basically a window on which new tabs aren't opened.
That doesn't hint about DOM. Same thing with GeckoView not scrolling, doesn't really smell a DOM issue.

Comment 6

[Randall Barker [:rbarker]]

Firefox Reality Github issue https://github.com/MozillaReality/FirefoxReality/issues/2897

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1616063 - Drop window features when opening popups in GeckoView

This isn't strictly correct, but a whole bunch of window features
make no sense or are harmful anyway. In this the test site
specifies scrollbars=no which seems to hose scrolling.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is working as designed per window features.