1616129 - [Wayland] Request libva >= 1.6 to build Firefox on Wayland

Status: RESOLVED DUPLICATE of bug 1616185

(Firefox Build System :: General, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

We need libva headers to build VAAPI decode support so define MOZ_WAYLAND_BUILD_VAAPI in this case.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1616129 [Wayland] Request libva >= 1.6 on Wayland to build VA-API support, r?glandium

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Mike, I'm not so skilled at the build setup hacking. What I need is to set MOZ_WAYLAND_BUILD_VAAPI when we're building on Wayland and also libva headers are present. We don't need libva libraries as we link it run-time but we need headers to build. There's a bunch of functions/structures I don't want to pre-define.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We want VA-API support built by default so request libva >= 1.6 to build Firefox on Wayland.

Comment 4

[Rinat]

Hi.
As far as I understand, your patches never use header files from libva. The library itself is loaded dynamically at run time, so the libxul.so is not linked with libva explicitly. So I believe libva package is not needed at build time.
Moreover, in https://phabricator.services.mozilla.com/D64093 you request libva.so.2, which was introduced only in versions 2.x of libva. It was libva.so.1 in 1.6.

I'd propose to drop this patch.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

We need to have appropriate <va/va.h> in build root.

Comment 6

[Rinat]

(In reply to Martin Stránský [:stransky] from comment #5)

We need to have appropriate <va/va.h> in build root.

OK.
I've seen the patch where you added #include <va/va.h> but in the next patches that line was removed. So I thought that <va/va.h> wasn't needed in the final patchset versions. Looks like I've missed something. Will try to read the diff's again.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Updated Bug 1616185 for it.