1616137 - @testpilot-containers Extension-Storage Collection maximum size exceeded with "Temporary Containers" extension also

Status: RESOLVED MOVED

(Core :: Security, defect, P3)

Description

[emailpublicwill]

Attachment: error-sync-1581977629178.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Tried to sync containers I've created across my devices (as it's a new feature for me).

Actual results:

Containers didn't sync

Expected results:

Expected containers from other devices to be sync'd to the Multi-Account Containers Extension

Comment 1

[emailpublicwill]

Oddly enough, after 30+ syncs, restarting the browser, etc. I'm starting to see some of my other device containers but continue to see the same

Sync.Engine.Extension-Storage	ERROR	Syncing @testpilot-containers: request failed: Error: HTTP 507 Insufficient Storage: Resource access is forbidden for this user (Collection maximum size exceeded (206888 > 204800 Bytes).)(resource://services-common/kinto-http-client.js:2771:5) JS Stack trace: [e-mail]:2771:5
[e-mail]:2925:13

error in the logs

Comment 2

[Virginia (please send need info request to Brindusa Tot)]

Hi,

Thanks for reporting this bug.

As a starting point, I'll add this ticket to the Firefox - Tabbed Browser component in the hope that someone with more expertise can take a look at it.

Can you please try to reproduce the issue on the latest Firefox Nightly and share the results with us?
You can download Firefox Nightly from here: https://nightly.mozilla.org/.

Thanks,
Virginia

Comment 3

[janet [:janet]]

Moving this to Core:Security where the container meta bug is also being triaged.

Comment 4

[Kendall]

Hi :emailpublicwill

Would you be willing to send us a copy of your local storage and/or sync storage (if possible) so we can take a look at this bug? This will give us your entire container and site assignment set up, so we might be able to reproduce the issue.

Here are steps to get a copy of your storage objects:

1. Open extension console: Go to about:debugging#/runtime/this-firefox, select "Inspect" on Multi-account Containers, and select the console tab
2. Get local identities list by typing await browser.contextualIdentities.query({});
3. Right click on the Array that is returned and select Copy Object, and paste into a text file.
4. Repeat steps 2-3 for local storage await browser.storage.local.get(); and sync storage: await browser.storage.sync.get(); (These will return an Object, not an Array.)
5. Save the file(s) and post them here. I have marked this bug as confidential so it is not open to the public.
6. Repeat steps for each computer that you have time/are willing to send us.

If not this, would you be willing to estimate how many Containers and Site Assignments you have and on how many computers you are syncing?

Thanks!

Comment 5

[Scott C]

I've got a similar error, I reviewed the three objects in this bugreport.

There was an anomaly in "await browser.storage.sync.get()" It has ~300 deletedIdentityList entries. I suspect it may be related to my use of the Temporary Containers[1] extension. I'm running 73.0.1 on Ubuntu 18.04.

I've (manually) created about 10 containers and mapped 30 or so URL's to them. However, Temporary Containers is happy to make (and churn) a lot more. I've been running it for a few months.

Currently, I've got about ~30 identity and identityState and ~40 siteContainerMap's from the queries you asked for. Nothing looks too anomalous in them, except I've churned through ~1400 userContextID's. (In that, the max userContextID I see in siteContainerMap is ~1400.) Normal URL's (and URL lengths) and UUID's.

I've got about 6 devices syncing. All but one are android devices. Last I heard, containers are desktop-only.

Is there something I can manually do to delete the deleted deletedIdentityList so sync doesn't break?

[1] moz-extension://a22c3973-9e51-4ca9-a34c-b7f66d101e71/manifest.json
"name": "Temporary Containers",
"version": "1.8",
"homepage_url": "https://github.com/stoically/temporary-containers",

Comment 6

[conta.srdr]

I have this issue as well and I am also using "Temporary containers", thus having big amount of containers.

Comment 7

[Daniel Veditz [:dveditz]]

There's a related github issue for temporary-containers: https://github.com/stoically/temporary-containers/issues/371

I imagine it would be possible to create enough containers to exceed the sync limits without the Temporary Containers extension, but probably unlikely in practice. One course of action would be to declare that "temporary" containers should not be sync'd, but that would mean Multi-Account Containers and Temporary Containers will have to figure out some way to coordinate that (might require a new "don't sync" flag/option/argument in the webextension API).

Luke: who would look into potential MAC Sync bugs now?

Comment 8

[Daniel Veditz [:dveditz]]

There's also one for MAC: https://github.com/mozilla/multi-account-containers/issues/1675

Maybe this is best "MOVED" there since the containers devs hang out more in github issues