1616162 - Tab bar does not go out of focus when browser.tabs.drawInTitlebar is enabled in GNOME 3.34.4

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Sibo Dong]

Attachment: Screencast of Firefox window switching

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

1. Log in to a Linux distribution with GNOME (3.34.4) as the desktop environment and Adwaita as the theme.
2. Open up Firefox 73.0 (and set brower.tab.drawInTitleBar to true so that there is no title bar).
3. Open another Firefox window so that there are now two windows positioned side by side.
4. Switch between the two windows with the keyboard (with Alt+Esc or Super+~).

Actual results:

When switching windows with the keyboard, the unfocused window's tab bar stays the same colour as the tab bar of a Firefox window that is currently in focus. This makes it hard to tell which window is currently in focus. There are no issues if browser.tab.drawInTitlebar is set to false (i.e. a title bar is present).

If I first mouse over the tab bar of the window I want to switch to, then the tab bar of the other window will correctly change colour after I click.

I have also observed this behaviour in Firefox Beta 74.0beta as well as Firefox Nightly 75.0a1 (built on February 17, 2020).

I've attached a screencast of the behaviour described above.

Expected results:

The unfocused window's tab bar should change to a different colour to indicate that it is unfocused while the focused window's tab bar should change to a darker shade to indicate that is currently in focus. This is the observed behaviour in Firefox 72.0.2.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Sibo Dong]

Attachment: mozregression output

Output from running mozregression --good 2019-10-21 --bad 2020-01-20

Comment 3

[Sibo Dong]

I installed and ran mozregression to try and determine the first bad build in which this bug appeared. I went to about:config of each build and set browser.tabs.drawInTitlebar to true and observed the behaviour when switching Firefox windows with the keyboard.

I've attached the output of mozregression --good 2019-10-21 --bad 2020-01-20 here.

Here are the last few lines of the output:

10:05.19 INFO: Narrowed integration regression window from [0bc4d935, 96122766] (3 builds) to [0bc4d935, 9eb877be] (2 builds) (~1 steps left)
10:05.19 INFO: No more integration revisions, bisection finished.
10:05.19 INFO: Last good revision: 0bc4d93567a76664acb2a5ba1fc081a4f0ec31f2
10:05.19 INFO: First bad revision: 9eb877be55acd8b5e27ea70a4d766946d5d8e60a
10:05.19 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bc4d93567a76664acb2a5ba1fc081a4f0ec31f2&tochange=9eb877be55acd8b5e27ea70a4d766946d5d8e60a

Comment 4

[Sibo Dong]

The output from mozregression for the nightly builds was:

 5:41.11 INFO: Narrowed nightly regression window from [2020-01-12, 2020-01-14] (2 days) to [2020-01-13, 2020-01-14] (1 days) (~0 steps left)
 5:41.11 INFO: Got as far as we can go bisecting nightlies...
 5:41.11 INFO: Last good revision: 0690f68a8d9984d2653792e3294bf876eecef651 (2020-01-13)
 5:41.11 INFO: First bad revision: 12d8255184b1015ff34f35c6fb040bbde6be2ed3 (2020-01-14)
 5:41.11 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0690f68a8d9984d2653792e3294bf876eecef651&tochange=12d8255184b1015ff34f35c6fb040bbde6be2ed3

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

So it's a regression from Bug 1600414
https://hg.mozilla.org/integration/autoland/rev/9eb877be55acd8b5e27ea70a4d766946d5d8e60a

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Hm I tested Yaru and Adwaita themes on Fedora 31 / gnome-shell-3.34.4-1.fc31.x86_64 and I don't see that. Which distro do you run?

Comment 8

[Sibo Dong]

I'm on Arch Linux.

Comment 9

[Sibo Dong]

The results from mozregression were done in an Xorg session, but I've noticed the same issue in a Wayland session as well. As mentioned before, I have noticed that mousing over the header bar does cause them to update correctly. Could this be related to this GNOME Shell issue mentioned here?

Comment 10

[Kestrel]

I see this on Ubuntu 19.10 (GNOME Shell 3.34.1) with Firefox 73+ (XWayland) with Adwaita theme.

Comment 11

[Sibo Dong]

I was able to reproduce this on a Fedora Workstation 32 Live image.

Comment 12

[Sibo Dong]

Not sure how or when this was resolved, but I can no longer replicate this issue with Firefox 89.0 and GNOME 40.1 (on both Wayland and Xorg). Closing.