1616188 - Add a shell flag to disable TI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1616188 part 1 - Add IsTypeInferenceEnabled and use it for type monitoring code. r?iain!

If TI is disabled we don't allocate any StackTypeSets in JitScript and we don't
allocate/use type monitor ICs.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1616188 part 2 - Use IsTypeInferenceEnabled to disable parts of heap TI. r?iain!

Unlike stack type monitoring, heap TI is much harder to disable completely
because it's intertwined with a lot of other things. This patch does the
following:

• Don't track type information for any ObjectGroups (in ObjectGroupRealm::makeGroup).

• Turn off heuristics for singletons, allocation-site groups, function groups.

• Turn off type update ICs in Baseline.

• Add early returns to some hot functions.

Depends on D63140

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1616188 part 3 - Add isTypeInferenceEnabled() function, use it to disable some jit-tests. r?iain!

Depends on D63141

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1616188 part 4 - Add a --no-ti shell flag. r?iain!

For now this is Nightly-only so that IsTypeInferenceEnabled() shouldn't
impact performance for our non-Nightly users.

Depends on D63143

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55c128f503c
part 1 - Add IsTypeInferenceEnabled and use it for type monitoring code. r=iain
https://hg.mozilla.org/integration/autoland/rev/444ff49a36c4
part 2 - Use IsTypeInferenceEnabled to disable parts of heap TI. r=iain
https://hg.mozilla.org/integration/autoland/rev/b337cc42de46
part 3 - Add isTypeInferenceEnabled() function, use it to disable some jit-tests. r=iain
https://hg.mozilla.org/integration/autoland/rev/011f24c76f1f
part 4 - Add a --no-ti shell flag. r=iain

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d55c128f503c
https://hg.mozilla.org/mozilla-central/rev/444ff49a36c4
https://hg.mozilla.org/mozilla-central/rev/b337cc42de46
https://hg.mozilla.org/mozilla-central/rev/011f24c76f1f