1616276 - Perma Iris ModuleNotFoundError: No module named 'gitdb.utils.compat'

Status: RESOLVED FIXED

(Testing :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=289211067&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/C415P57gRl-lhQz2ndnc5Q/runs/0/artifacts/public/logs/live_backing.log

---

This failure stems from a change outside the tree as retriggers on previously passing pushes also fail now. Comparison of a successful and a failing log didn't reveal an obvious change.

[task 2020-02-17T12:15:23.147Z] # Run the iris test suite
[task 2020-02-17T12:15:23.148Z] python3 -m pipenv run iris $irisstring -w ../../iris_runs -n --treeherder -f ../../fetches/firefox/firefox.exe -y
[task 2020-02-17T12:15:23.148Z] + python3 -m pipenv run iris nightly -w ../../iris_runs -n --treeherder -f ../../fetches/firefox/firefox.exe -y
[task 2020-02-17T12:15:28.920Z] Traceback (most recent call last):
[task 2020-02-17T12:15:28.920Z] File "C:\Users\task_1581939285\scoop\apps\python\current\Lib\runpy.py", line 193, in run_module_as_main
[task 2020-02-17T12:15:28.920Z] "main", mod_spec)
[task 2020-02-17T12:15:28.920Z] File "C:\Users\task_1581939285\scoop\apps\python\current\Lib\runpy.py", line 85, in run_code
[task 2020-02-17T12:15:28.920Z] exec(code, run_globals)
[task 2020-02-17T12:15:28.920Z] File "C:\Users\task_1581939285.virtualenvs\iris_firefox-U7czXQKZ\Scripts\iris.exe_main.py", line 4, in <module>
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\moziris\scripts\main.py", line 24, in <module>
[task 2020-02-17T12:15:28.920Z] from moziris.control_center.commands import delete
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\moziris\control_center\commands.py", line 11, in <module>
[task 2020-02-17T12:15:28.920Z] from moziris.util.path_manager import PathManager
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\moziris\util\path_manager.py", line 13, in <module>
[task 2020-02-17T12:15:28.920Z] import git
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\git_init.py", line 38, in <module>
[task 2020-02-17T12:15:28.920Z] from git.exc import * # @NoMove @IgnorePep8
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\git\exc.py", line 9, in <module>
[task 2020-02-17T12:15:28.920Z] from git.compat import UnicodeMixin, safe_decode, string_types
[task 2020-02-17T12:15:28.920Z] File "c:\users\task_1581939285.virtualenvs\iris_firefox-u7czxqkz\lib\site-packages\git\compat.py", line 16, in <module>
[task 2020-02-17T12:15:28.920Z] from gitdb.utils.compat import (
[task 2020-02-17T12:15:28.920Z] ModuleNotFoundError: No module named 'gitdb.utils.compat'

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bob, do you have any insight what changed here? Releaseduty is not aware of any package updates on Sunday or Monday morning. Last passing and first failing push + failed retrigger on previously passing push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Cusercancel%2Cretry%2Ctestfailed%2Cbusted%2Cexception&tier=1%2C2%2C3&searchStr=iris&tochange=114d8b270dbb4d512650b3918b87d71dbc83ad50&fromchange=3b823d058ef541ec6abd5e781c6b9b4e1b893fbf

Comment 2

[Bob Clary [:bc] (inactive)]

Tracy: Can you help here? I can't determine which ranjit is associated with iris from the github repo. There were no recent changes to the iris repo that I can see.

There were changes to https://github.com/gitpython-developers/gitdb/commits/master/gitdb/utils on February 16.

Bug 1615786 touched taskcluster/ci/fetch/toolchains.yml, didn't touch iris but it occurred around the same time.

Shravanrn: It doesn't appear to me that your changes would have this effect but do you have any idea if your changes changed the dependencies of the packages which resulted in this error?

Comment 3

[Tracy Walker [:tracy]]

Since the layoffs, the Iris test tool project is no longer supported. Decision was to let Iris run in treeherder until something like this happened. I've been monitoring test runs in treeherder. The last failure shows a re-run that passed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&tier=1%2C2%2C3&revision=3b823d058ef541ec6abd5e781c6b9b4e1b893fbf&searchStr=iris%2Cnightly-windows10-64-shippable%2Fopt. Did something out of Mozilla's control fix the permafail?

Since there is no team or individuals to support this test suite. even if this current issue is fixed, this test suite will eventually rot over time against Nightly. Iris on treeherder should be disabled.

Comment 4

[Bob Clary [:bc] (inactive)]

Tracy: Thanks! Iris was initially landed in bug 1573271. Can you remove Iris or should we find someone to take care of it?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Tracy Walker [:tracy] from comment #3)

The last failure shows a re-run that passed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&tier=1%2C2%2C3&revision=3b823d058ef541ec6abd5e781c6b9b4e1b893fbf&searchStr=iris%2Cnightly-windows10-64-shippable%2Fopt.
The orange task ran after the passing green one. The order how they are displayed is chronologically incorrect.

Have you heard anything about Iris resourcing since the All Hands?

Comment 6

[Tracy Walker [:tracy]]

There is a possibility we'll want to support Iris again in the future. As such, is it possible to simply turn it off without completely removing it? I don't know how to do either.

Comment 7

[Bob Clary [:bc] (inactive)]

That should be easily doable. I'll get a patch ready.

Comment 8

[Tracy Walker [:tracy]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #5)

(In reply to Tracy Walker [:tracy] from comment #3)

The last failure shows a re-run that passed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&tier=1%2C2%2C3&revision=3b823d058ef541ec6abd5e781c6b9b4e1b893fbf&searchStr=iris%2Cnightly-windows10-64-shippable%2Fopt.
The orange task ran after the passing green one. The order how they are displayed is chronologically incorrect.

Ok, that makes sense.

Have you heard anything about Iris resourcing since the All Hands?

It's on hold until Desktop QA sorts out if/how they want to use it.

Comment 9

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1616276 - Disable Iris test suite due to lack of resources, r=tomprince.

Comment 10

[Shravan Narayan]

Shravanrn: It doesn't appear to me that your changes would have this effect but do you have any idea if your changes changed the dependencies of the packages which resulted in this error?

I don't believe so. To my knowledge , the features I am currently updating aren't using iris tests.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b42456739b1
Disable Iris test suite due to lack of resources, r=jmaher.

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9b42456739b1

Comment 13

[Intermittent Failures Robot]

1 failures in 4045 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1616276&startday=2020-02-17&endday=2020-02-23&tree=all

Comment 14

[Julien Cristau [:jcristau]]

Wondering if it's time to remove this code now?

Comment 15

[Tracy Walker [:tracy]]

(In reply to Julien Cristau [:jcristau] from comment #14)

Wondering if it's time to remove this code now?

Yes, there won't be any plan to resurrect Iris.