1616306 - Merge splitInputAtLastPropertyAccess into analyzeInputString

Status: RESOLVED FIXED

(DevTools :: Console, task, P2)

Description

[nightwarriorftw]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

While accessing elements i.e inside [ use dot . operator.
Example :-
Evaluate this in console -
x = {["weird.[.]one"]: "plouf", ["weird.[.]second"]: "plaf", "weird": false}
Type -
x["weird.[
Now, here matchProp will return an empty string.

Actual results:

matchProp returns an empty string.

Expected results:

It should have returned something useful which we can use to retrieve from cache. But since it returned an empty string we can't retrieve from cache.

In order to solve this problem we can probably merge splitInputAtLastPropertyAccess into analyzeInputString function in order to retrieve something useful such that we can use that information to retrieve the autocomplete part from cache.
This Bug is blockage for Bug 1536088

Comment 1

[nightwarriorftw]

Attachment: Bug 1616306-Merge splitInputAtLastPropertyAccess into analyzeInputString, r=nchevobbe

Comment 2

[nightwarriorftw]

Attachment: Bug 1616306-Merge splitInputAtLastPropertyAccess into analyzeInputString, r=nchevobbe

Comment 3

[nightwarriorftw]

Attachment: Bug 1616306 - Merge splitInputAtLastPropertyAccess into analyzeInputString, r=nchevobbe

Comment 4

[nightwarriorftw]

Attachment: Bug 1616306 - Merge splitInputAtLastPropertyAccess into analyzeInputString, r=nchevobbe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c6c704629c
Merge splitInputAtLastPropertyAccess into analyzeInputString, r=nchevobbe

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/61c6c704629c