1616322 - Update Async Stack UI

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

Now that we show captured frames, we should update the look and feel to show async causes as separators

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1616322 - Update Async Stack UI. r=loganfsmyth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec76d0f0399
Update Async Stack UI.

Comment 3

[Cristian Brindusan [:cbrindusan]]

:jlast, I've noticed that this changeset was landed without the reviewer, can you please make sure to get patches landed properly in the future (e.g. with reviewer and author of the landed code different)? Thank you!

Comment 4

[Logan Smyth [:loganfsmyth]]

That's on me, I accepted the revision but there was one small linter failure. Instead of waiting for Jason, I commandeered the patch and fixed the lint failure and landed it all.

It looks like when I commandeered the revision, it cleared the review state and I couldn't mark it as reviewed because it was now owned by me.

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/aec76d0f0399

Comment 6

[Cristian Brindusan [:cbrindusan]]

Thank you Logan for your input and clarifications!

Comment 7

[Logan Smyth [:loganfsmyth]]

@Cristian Is there anything I should have done differently here, or something that could be changed in the Phabricator workflow to avoid confusion like this? For instance, if I were able to push a small change to the patch without commandeering, we could avoid this confusion, or if Phabricator hadn't automatically changed the reviewer to Jason and cleared the review state when I commandeered the patch.

Comment 8

[Cristian Brindusan [:cbrindusan]]

I think that Aryx can fully answer your question here, ty.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From recent observations, in general the patch author addresses the review comments and pushes. What could have done is to pick "Edit Revision" in Phabricator and edit the commit message there to add r=you.