1616379 - MOZ_ASSERT_UNREACHABLE: invalid hyphenation resource? in nsHyphenator.cpp when loading addons.mozilla.org

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

STR: Load https://addons.mozilla.org/en-US/firefox/addon/unload-tab-from-context-menu/ in a debug build.

Comment 1

[Jonathan Kew (:jfkthame)]

Huh, I wonder what hyphenation it's even trying to load. Will look into it...

Comment 2

[Jean-Yves Avenard [:jya]]

is there any updates on this?

It makes the use of debug build close to impossible as we always hit this assertion sooner or later.

At least disable the crash assertion and make that a NS_ASSERTION instead.

Comment 3

[Jonathan Kew (:jfkthame)]

I've tried to reproduce this (loading URL from comment 0 with a debug build), but have not seen the problem. Do you have any other STR?

Comment 4

[Jonathan Kew (:jfkthame)]

Anyhow, I guess we can safely change this to NS_ASSERTION, as although this is unexpected -- it seems to suggest either something is broken/mispackaged in the build, or maybe we're out of memory? -- it should still be safe.

Comment 5

[Jonathan Kew (:jfkthame)]

Attachment: Bug 1616379 - Weaken the MOZ_ASSERT on failing to load a hyphenation resource to an NS_ASSERTION. r=jya

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/740634c137bb
Weaken the MOZ_ASSERT on failing to load a hyphenation resource to an NS_ASSERTION. r=jya

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/740634c137bb

Comment 8

[Jonathan Kew (:jfkthame)]

Matt, Jean-Yves: do you recall, were you both using Windows when you ran into this, by any chance?

Comment 9

[Matt Woodrow (:mattwoodrow)]

Yeah, I was using Windows at the time.

Comment 10

[Jean-Yves Avenard [:jya]]

(In reply to Jonathan Kew (:jfkthame) from comment #8)

Matt, Jean-Yves: do you recall, were you both using Windows when you ran into this, by any chance?

I was indeed.

Comment 11

[Jonathan Kew (:jfkthame)]

OK, thanks -- that was the important detail I didn't realize. Filed bug 1650013 to actually fix this.