1616480 - {Mac} Clear Recent History dialog no longer responds to keyboard inputs

Status: RESOLVED DUPLICATE of bug 1615854

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[carmudgeon]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

1. Invoke Clear Recent History dialog

2. Confirm selections and press Return on keyboard

Actual results:

Nothing..

The dialog no longer responds to keyboard inputs as with versions prior to v73.

Neither the Return key (to proceed), or the Escape key (to cancel) result in any action.

Tested with all extensions disabled, and the result is the same.

Expected results:

The Clear Now (default) button should have been been triggered by the Return key press, and the action completed.

This is not consistent with the OS behavior, even for actions that may be considered destructive, and non-reversible.

For instance, if the user has elected to require confirmation before the Empty Trash action is performed, the resulting dialog has the affirmative Empty Trash button as the default, highlighted in blue, and it can be triggered by both the mouse pointer as well as the keyboard.

Comment 1

[Daniel Bodea [:danibodea]]

I have tested this issue on more MAC OS versions since it appears to influence the results:

1. Mac OS 10.13.6:
   a. Nightly v75.0a1 - does NOT occur
   b. Beta v74.0b7 - does NOT occur
   c. Release v73.0.1 - does NOT occur
   d. ESR v68.5.0esr - does NOT occur

2. Mac OS 10.13:
   a. Nightly v75.0a1 - does occur
   b. Beta v74.0b7 - does occur
   c. Release v73.0.1 - does occur
   d. ESR v68.5.0esr - does NOT occur

3. Mac OS 10.14.6:
   a. Nightly v75.0a1 - does occur
   b. Beta v74.0b7 - does occur
   c. Release v73.0.1 - does occur
   d. ESR v68.5.0esr - does NOT occur

4. Mac OS 10.15.3:
   a. Nightly v75.0a1 - does occur
   b. Beta v74.0b7 - does occur
   c. Release v73.0.1 - does occur
   d. ESR v68.5.0esr - does NOT occur

Comment 2

[Henri Sivonen (:hsivonen)]

Is this Gecko or UI code problem?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Not sure. We landed only 5 patches to widget/cocoa/TextInputHandler.mm.
https://hg.mozilla.org/mozilla-central/log/tip/widget/cocoa/TextInputHandler.mm

I need the regression-window.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Bodea Daniel [:danibodea] from comment #1)

I have tested this issue on more MAC OS versions since it appears to influence the results:

Since you have the systems needed to repro, could you, please, bisect the regression window?

Comment 5

[Daniel Bodea [:danibodea]]

Weirdly enough, I could not reproduce the same issue on Mac OS 10.14.6, although I DID 3 days ago, on the same system.
On the other hand, I switched to Mac OS 10.13 and I could reproduce and perform the regression test:

8:38.01 INFO: No more integration revisions, bisection finished.
18:38.01 INFO: Last good revision: 88b25807638231dcf403d8f0b597fc770f1d24a4
18:38.01 INFO: First bad revision: e183cbb4983cfb3aecf97ab18fad916b91f89e7e
18:38.01 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88b25807638231dcf403d8f0b597fc770f1d24a4&tochange=e183cbb4983cfb3aecf97ab18fad916b91f89e7e

Comment 6

[Brian Grinstead [:bgrins]]

I have a patch in Bug 1615854 that will fix this.