1616512 - Reps visual polish: indent guide, selected row

Status: NEW

(DevTools :: Debugger, enhancement, P3)

Description

[Florens Verschelde :fvsch]

Attachment: reps-visual-tweaks.png

Some possible improvements:

• Small border-radius for focused rows
• Shift arrow a bit to the right? Currently it's overflowing a bit from focused rows, but the current alignment might be necessary in Debugger's SecondaryPanes?
• Arrow vertical alignment: hard to get right, it's shifted with a margin-top: -1px which is ignored on 1x displays.
• The indent guide could use the same colors as the indent guide in Inspector's Markup view:

.theme-light {
  --markup-outline: var(--theme-splitter-color); /* light gray */
}
.theme-dark {
  --markup-outline: var(--theme-selection-background); /* dark blue */
}

Comment 1

[Mohammed Jan :mjan]

Hi! I would like to contribute to this project, can I work on this?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, please!

Assigned to you.

Honza

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 4

[ola-oluwa]

Hi @Honza Can I get this please

Comment 5

[ola-oluwa]

Solved this bug
Can I submit the patch?

Comment 6

[Hubert Boma Manilla (:bomsy)]

Sure assigned to you.

Comment 7

[ola-oluwa]

Attachment: Bug 1616512- Reps visual polish: indent guide, selected row. r?jdescottes,bomsy,fvsch

Depends on D128878

Comment 8

[ola-oluwa]

Hello bomsy

Here is a first try at fixing this, Please let me know if there is anything to add or modify

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[[:nickname] SamuelK]

Hi there,

I see there is some work on this bug. Can i take it over and use the existing code to get this wrapped up?

Thanks,
Samuel