1616516 - Simplify ObjectGroup::defaultNewGroup a bit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

The clasp argument can be nullptr if there's an associated function, but that was just for unboxed objects. We should change the callers to pass the PlainObject class directly so we can simplify defaultNewGroup a bit.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1616516 - Always use non-null clasp argument for ObjectGroup::defaultNewGroup and table lookup. r?iain!

The nullptr class mechanism was added for unboxed objects: because a group with a
PlainObject class could be mutated into a group with an UnboxedPlainObject class,
if we did a lookup with the PlainObject class we would no longer find the group
in the table.

With unboxed objects gone, a group's class can no longer change so we can (again)
always use a non-nullptr class for the table lookup.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acc0c8327c26
Always use non-null clasp argument for ObjectGroup::defaultNewGroup and table lookup. r=iain

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/acc0c8327c26