Closed Bug 1616636 Opened 4 years ago Closed 4 years ago

Setup WNP for users coming from <74.0 and receiving the 74.0 release

Categories

(Release Engineering :: Release Requests, enhancement)

Product:
Release Engineering
Component:
Release Requests
Type:
enhancement
Priority:
Not set
Severity:
major

Tracking

(firefox74 fixed, firefox75 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox74 --- fixed
firefox75 --- fixed

People

(Reporter: erenaud, Assigned: jlund)

References

(
URL
)

Details

(Whiteboard: [releaseduty])

Attachments

(1 file)

Bug 1616636 - Setup WNP for users coming from <74.0 and receiving the 74.0 release, r?aki
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

Request is to have the product point to the /whatsnew page in the Firefox 74.0 release and show it (WNP).

  • All users coming from <74.0 and receiving the 74.0 release should be shown the WNP 74.0 page.

  • id - has a hard coded template not reflected in Pontoon and will need to be added to the final list of locales, which Peiying will provide in this bug on March 3rd

  • Users in locales at 100% will be shown the content in the WNP 74.0 page (we'll assign that content to the WNP URL). We know we'll have de, en-CA, en-GB, en-US, fr for sure.

  • for locales w/o content, they should not be shown a page (does not default to en-US)

  • github issue for this work is here

Assignee: nobody → sfraser

Hi cocomo: it's that time again already. Can you provide a list of locales we would like to provide a whatsnewpage to? We need this by tomorrow (Friday, Feb 28th)

Assignee: sfraser → jlund
Flags: needinfo?(pmo)
Blocks: 1607246

(In reply to Jordan Lund (:jlund) from comment #1)

Hi cocomo: it's that time again already. Can you provide a list of locales we would like to provide a whatsnewpage to? We need this by tomorrow (Friday, Feb 28th)

Unfortunately, I don't even have the English page set up in a template for me to process. I was told that de and fr will be hard coded as they are localized by staff. If I need to give you the list by Friday morning (Feb 28th), these three are guaranteed locales.

@Eric, if there is a fallback page, is it WNP73? I can provide a list of that.

Flags: needinfo?(pmo)
Flags: needinfo?(erenaud)

@:jlund, the page was made available for localization last night. This is what we have this far, a total of 38. Note:
1). Locales in bold have finished WNP74 (11 locales).
2). The rest have completed WNP73 (38 locales), which is the fallback page.
3). de, fr are completed by staff. However, I get conflicting messages on how it is done. If the pages are hard coded, I have no visibility. If they are pieced together between Pontoon and hard coded strings (unique for de and fr), German is done for WNP74, but French is not (will fall back to WNP73).

  • be,
  • cak,
  • cy,
  • da,
  • de,
  • dsb,
  • en-CA,
  • en-GB,
  • es-AR,
  • es-CL,
  • es-ES,
  • fr,
  • fy-NL,
  • gn,
  • hsb,
  • hu,
  • ia,
  • id,
  • it,
  • ka,
  • nl,
  • nn-NO,
  • pa-IN,
  • pl,
  • pt-BR,
  • pt-PT,
  • ro,
  • sk,
  • sl,
  • sq,
  • sv-SE,
  • tr,
  • uk,
  • vi,
  • zh-CN,
  • zh-TW,

(In reply to Peiying Mo [:CocoMo] from comment #3)

3). de, fr are completed by staff. However, I get conflicting messages on how it is done. If the pages are hard coded, I have no visibility. If they are pieced together between Pontoon and hard coded strings (unique for de and fr), German is done for WNP74, but French is not (will fall back to WNP73).

They are pieced together. The bulk of the page consists of normal strings in Pontoon, but there is one block of content that is hard-coded in French (it links to a French blog post). Conditional logic in the template determines whether that one block is visible or not. However, we'll still rely on lang file activation to determine if the template loads at all for French. If for some reason the page isn't ready (lang file not active), French will then fall back to the 73 page.

Pushed by jlund@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e83b2dc316b8
Setup WNP for users coming from <74.0 and receiving the 74.0 release, r=aki

Comment on attachment 9129911 [details]
Bug 1616636 - Setup WNP for users coming from <74.0 and receiving the 74.0 release, r?aki

Beta/Release Uplift Approval Request

  • User impact if declined: needs to be in before we merge m-b->m-r on Monday, March 2nd, and start the release
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9129911 - Flags: approval-mozilla-beta?

Comment on attachment 9129911 [details]
Bug 1616636 - Setup WNP for users coming from <74.0 and receiving the 74.0 release, r?aki

Approved for 74.0RC1.

Attachment #9129911 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

https://hg.mozilla.org/mozilla-central/rev/e83b2dc316b8

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED

We have tested WNP along with our update tests.
While all our update tests have passed, please note that the WNP results do not meet the expected criteria.

Here are a few examples of the encountered issues:

  • en-GB is listed as eligible for 74 WNP - it DOES NOT receive either the 74 WNP or the 73 WNP - example
  • pt-PT is listed as eligible for 73 WNP - it does not receive the 73 WNP
  • ka is listed as eligible for 74 WNP - it DOES NOT receive either the 74 WNP or the 73 WNP example

The full list of results can be found at this link.

Flags: needinfo?(pmo)

Apologies, the 74 page is not yet live in production. I'm hoping to have it live today, certainly by tomorrow.

Flags: needinfo?(pmo)

Hello,

After running test on RC 74.0 RC2 on release-localtest, update tests and WNP worked as expected, except for the id (Indonesian) locale that did not receive any WNP at all even if according to this bug it should have the 73 WNP fallback page.

The page for Indonesian exists https://www.mozilla.org/id/firefox/74.0/whatsnew/all/ and I see it listed in the code on mozilla-release, I also see it listed in the release-localtest rules in Balrog so I am out of ideas. Jordan would you have an idea about it?

Flags: needinfo?(jlund)

Confirming here that the Balrog response does include openURL for 'id' for mac/linux/windows.

I tried installing Mac 73.0 in the 'id' locale on another machine, changed the release channel to release-localtest, and I saw the page linked above in comment #15 when it restarted. What should be the expected behaviour?

Flags: needinfo?(jlund)

@Eric in his initial bug filing indicate that the page is hardcoded as it would point to Firefox Lite, not the regular page that other locale gets. That content does not come from the community. Need Eric to comment on this.

I am not clear on the correct behavior to see the page though.

sfraser's test confirms the requirement, which is to show the hardcoded template with Firefox Lite content in it to users with 'id' set as their preferred language.

Flags: needinfo?(erenaud)

Hello,

I can confirm that that is the page that we saw https://www.mozilla.org/id/firefox/74.0/whatsnew/all/ however we were confused because there was no mention that the id page was hardcoded to be different than the rest.

Peiying, QA reports that they're seeing more locales receiving the localized 74 WNP than outlined in comment 3. Is there an updated list of translated locales so their test results can be verified?

Flags: needinfo?(pmo)

Note, WNP74 was made available to l10n communities less than 24 hours before I was due to provide the list, and WNP73 was the fallback page. Since then, we have a few more locales completed WNP74 - highlighted in bold text.
-- de, fr pages are made up by Pontoon+hard coded strings
-- id is hard coded and serves with different content.

  • be,
  • cak,
  • cy,
  • da,
  • de,
  • dsb,
  • en-CA,
  • en-GB,
  • es-AR,
  • es-CL,
  • es-ES,
  • fr,
  • fy-NL,
  • gn,
  • hr,
  • hsb,
  • hu,
  • ia,
  • id,
  • it,
  • ka,
  • ko,
  • nl,
  • nn-NO,
  • pa-IN,
  • pl,
  • pt-BR,
  • pt-PT,
  • ro,
  • sk,
  • sl,
  • sq,
  • sv-SE,
  • tr,
  • uk,
  • vi,
  • zh-CN,
  • zh-TW,
Flags: needinfo?(pmo)

Hello,

I can see in your latest comment that hr is in bold but we do not receive any 74 WNP for it, in fact we didn't receive the 74 or 73 WNP.

Flags: needinfo?(pmo)

The list of locales configured to show WNP hasn't changed it's the one from comment 3.

Flags: needinfo?(pmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: