Open Bug 1616766 Opened 5 years ago Updated 2 years ago

Review usage of access key in Style Editor UI

Categories

(DevTools :: Style Editor, task, P3)

task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

Follow up to Bug 1608199 , see discussion at https://phabricator.services.mozilla.com/D59607#inline-381285

The style editor defines access keys for 3 icon buttons and 1 link:

  • import button
  • new button
  • toggle visibility button
  • save link (display next to each stylesheet)

For the 3 buttons, they have no label so the access key seems irrelevant (or at least not discoverable). And for the save link, I was unable to use the access key to trigger the action save action, so we should check if this is a valid use case.

Bug 1608199 is switching the styleeditor from dtd to ftl, so we should wait until it lands to address this bug.

https://searchfox.org/mozilla-central/rev/fca0be7e2cf2f922c9b927423ce28e8a04b3fd90/devtools/client/styleeditor/index.xhtml#99,102,130,140

           <toolbarbutton class="style-editor-newButton devtools-toolbarbutton"
                        accesskey="&newButton.accesskey;"
                        tooltiptext="&newButton.tooltip;"/>
            <toolbarbutton class="style-editor-importButton devtools-toolbarbutton"
                        accesskey="&importButton.accesskey;"
                        tooltiptext="&importButton.tooltip;"/>
<!-- ... -->
        <label class="stylesheet-enabled" tabindex="0"
          tooltiptext="&visibilityToggle.tooltip;"
          accesskey="&saveButton.accesskey;"></label>
<!-- ... -->
            <html:h3><label class="stylesheet-saveButton"
                  tooltiptext="&saveButton.tooltip;"
                  accesskey="&saveButton.accesskey;">&saveButton.label;</label></html:h3>

FWIW, web content access keys have different modifiers than the main app ones, so that might be part of what's happening here - I don't know how we make the determination (principal/privilege level of the page? process type? URL?) as to which of them we use, but worth bearing in mind when testing to see if this does anything.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.