Closed Bug 1616805 Opened 4 years ago Closed 4 years ago

Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission

Categories

(Toolkit :: Reader Mode, task, P3)

Product:
Toolkit
Component:
Reader Mode
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Project Flags:
Fission Milestone M6c
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Bug 1616805 - Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission.
47 bytes, text/x-phabricator-request
Details | Review

I'm going to mark toolkit/components/reader/test/browser_readerMode_with_anchor.js skipped in Fission. This bug is about re-enabling it.

See Also: → 1616338
Priority: -- → P3

Tracking for Fission mochitests (M4.1)

Fission Milestone: --- → M4.1

Gijs, can you please help find an engineer to fix and re-enable this Reader Mode test for Fission?

The test is skipped for Fission here:

https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/toolkit/components/reader/test/browser.ini#15-16

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Chris Peterson [:cpeterson] from comment #2)

Gijs, can you please help find an engineer to fix and re-enable this Reader Mode test for Fission?

The test is skipped for Fission here:

https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/toolkit/components/reader/test/browser.ini#15-16

I'm not a manager so I can't really find engineers... and I don't really have time to dive into this myself right now. Henri disabled this, maybe he has at least some inkling of what is needed to re-enable this?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(hsivonen)

Try run looks good. I'll try again with more platforms just in case.

Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Flags: needinfo?(hsivonen)

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Fission Milestone: M4.1 → M6c
Flags: needinfo?(cpeterson)

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Sounds good since the dependency (bug 1634363) is an M6 bug.

Severity: normal → S3
Type: defect → task
Flags: needinfo?(cpeterson)

In bug 1638027 Andrew hypothesises that the repeated creation/destruction of workers is to blame for the leaks in the trypush...

See Also: → 1638027
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c721f95976d7
Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/c721f95976d7

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: