1616805 - Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, task, P3)

Description

[Henri Sivonen (:hsivonen)]

I'm going to mark toolkit/components/reader/test/browser_readerMode_with_anchor.js skipped in Fission. This bug is about re-enabling it.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission mochitests (M4.1)

Comment 2

[Chris Peterson [:cpeterson]]

Gijs, can you please help find an engineer to fix and re-enable this Reader Mode test for Fission?

The test is skipped for Fission here:

https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/toolkit/components/reader/test/browser.ini#15-16

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #2)

Gijs, can you please help find an engineer to fix and re-enable this Reader Mode test for Fission?

The test is skipped for Fission here:

https://searchfox.org/mozilla-central/rev/3ce874dc2703831af3e5ef3a1d216ffd08057fa5/toolkit/components/reader/test/browser.ini#15-16

I'm not a manager so I can't really find engineers... and I don't really have time to dive into this myself right now. Henri disabled this, maybe he has at least some inkling of what is needed to re-enable this?

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1616805 - Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission.

Comment 5

[Henri Sivonen (:hsivonen)]

Try run with patch for bug 1634363:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cce93683feb47dbf438098af7b4ed7250b96e5c2

Comment 6

[Henri Sivonen (:hsivonen)]

Try run looks good. I'll try again with more platforms just in case.

Comment 7

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c20b1c9adabf5a375aad48c8d7ce886b433bd8f5

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Sounds good since the dependency (bug 1634363) is an M6 bug.

Comment 10

[:Gijs (out for now; he/him)]

In bug 1638027 Andrew hypothesises that the repeated creation/destruction of workers is to blame for the leaks in the trypush...

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c721f95976d7
Re-enable toolkit/components/reader/test/browser_readerMode_with_anchor.js for Fission. r=Gijs

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c721f95976d7