Closed Bug 1616867 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21901 - Add support for print reftests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(3 files)

Sync web-platform-tests PR 21901 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21901
Details from upstream follow.

James Graham <james@hoppipolla.co.uk> wrote:

Add support for print reftests

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9f69e384ff7 [wpt PR 21901] - Add support for print reftests, a=testonly
Test result changes from PR not available.

Automatic update from web-platform-tests
Fix support for StaticHandler without format_args

--
Support multiple PNGs per reftest comparison

This paves the way for print reftests in which each page will be a
seperate image. At present none of the output formats actually support
multiple images, so we always have to pick a single image to actually
output.

--
Add print-reftest support to the manifest

This adds a new test type to the manifest called print-reftest. Print
reftests are distinguished from normal reftests by filenames
containing -print as the type flag, or by being in directories called
'print'.

--
Vendor pdf.js

This only takes the compiled files necessary for our use case (in
particular build/pdf.js and build/pdf.worker.js from the PDFjs
distribution

--
Add basic print reftest support to marionette executor

Adds support for print reftests, as set out in RFC 41 [1]. This is
based on the WebDriver Print endpoint, using pdf.js to render the
pages of the generated PDF back to PNGs for comparison. The pdf.js
process itself runs in the browser, so there's quite a lot of
back-and-forth traffic involved; this approach is not fast. But we're
unlikely to get too many print reftests, so it's a useful baseline.

https://github.com/web-platform-tests/rfcs/pull/41

--
Add print reftest infrastructure test

--
Support print reftests in Chrome

This uses the underlying CDP command directly since PDF generation
isn't yet supported in Chrome. It also requires the browser to run in
headless mode since PDF generation is only supported in this mode.

--
Move wdspec detection higher in the order of precedence

This is primarilly so that print.py doesn't show up as a print reftest, but
also because wdspec tests are pretty easy to identify unambigously since they're
in a single subtree and are all python files.

--
Rename one WebDriverProtocol class as WdspecProtocol

This naming clash caused a confusing bug; really this class is only for wdspec tests.

--
Fix typo in docstring

Co-authored-by: Stephen McGruer <smcgruer@chromium.org>

--

wpt-commits: 14318a51c8bbb4f93da025d873d0cadcc352f19e, 7f8fed23452026c68eed6d2987eaef13b9a7f561, 13ec04fe7ba89fc2e532c710acb0afbcb4db3715, 96f15e060633d1c2470353acf1e23c31d85897d9, ed440d946653bfbd53eef6cd76314f548bdabeda, 51815349ffae146d3a822a1d9d72046a492709db, c8447fe1835f792d109a019523aca7cdfc6dd72d, b0e3c1ce95151503be5037c2888563f19cc5875e, 7ef00b794ca222b6e59b27997e0bc67c0398a7d6, e06c2c218f9a95d1a18cd175fddd6fe3d3a04d02
wpt-pr: 21901

Automatic update from web-platform-tests
Fix support for StaticHandler without format_args

--
Support multiple PNGs per reftest comparison

This paves the way for print reftests in which each page will be a
seperate image. At present none of the output formats actually support
multiple images, so we always have to pick a single image to actually
output.

--
Add print-reftest support to the manifest

This adds a new test type to the manifest called print-reftest. Print
reftests are distinguished from normal reftests by filenames
containing -print as the type flag, or by being in directories called
'print'.

--
Vendor pdf.js

This only takes the compiled files necessary for our use case (in
particular build/pdf.js and build/pdf.worker.js from the PDFjs
distribution

--
Add basic print reftest support to marionette executor

Adds support for print reftests, as set out in RFC 41 [1]. This is
based on the WebDriver Print endpoint, using pdf.js to render the
pages of the generated PDF back to PNGs for comparison. The pdf.js
process itself runs in the browser, so there's quite a lot of
back-and-forth traffic involved; this approach is not fast. But we're
unlikely to get too many print reftests, so it's a useful baseline.

https://github.com/web-platform-tests/rfcs/pull/41

--
Add print reftest infrastructure test

--
Support print reftests in Chrome

This uses the underlying CDP command directly since PDF generation
isn't yet supported in Chrome. It also requires the browser to run in
headless mode since PDF generation is only supported in this mode.

--
Move wdspec detection higher in the order of precedence

This is primarilly so that print.py doesn't show up as a print reftest, but
also because wdspec tests are pretty easy to identify unambigously since they're
in a single subtree and are all python files.

--
Rename one WebDriverProtocol class as WdspecProtocol

This naming clash caused a confusing bug; really this class is only for wdspec tests.

--
Fix typo in docstring

Co-authored-by: Stephen McGruer <smcgruer@chromium.org>

--

wpt-commits: 14318a51c8bbb4f93da025d873d0cadcc352f19e, 7f8fed23452026c68eed6d2987eaef13b9a7f561, 13ec04fe7ba89fc2e532c710acb0afbcb4db3715, 96f15e060633d1c2470353acf1e23c31d85897d9, ed440d946653bfbd53eef6cd76314f548bdabeda, 51815349ffae146d3a822a1d9d72046a492709db, c8447fe1835f792d109a019523aca7cdfc6dd72d, b0e3c1ce95151503be5037c2888563f19cc5875e, 7ef00b794ca222b6e59b27997e0bc67c0398a7d6, e06c2c218f9a95d1a18cd175fddd6fe3d3a04d02
wpt-pr: 21901

Automatic update from web-platform-tests
Fix support for StaticHandler without format_args

--
Support multiple PNGs per reftest comparison

This paves the way for print reftests in which each page will be a
seperate image. At present none of the output formats actually support
multiple images, so we always have to pick a single image to actually
output.

--
Add print-reftest support to the manifest

This adds a new test type to the manifest called print-reftest. Print
reftests are distinguished from normal reftests by filenames
containing -print as the type flag, or by being in directories called
'print'.

--
Vendor pdf.js

This only takes the compiled files necessary for our use case (in
particular build/pdf.js and build/pdf.worker.js from the PDFjs
distribution

--
Add basic print reftest support to marionette executor

Adds support for print reftests, as set out in RFC 41 [1]. This is
based on the WebDriver Print endpoint, using pdf.js to render the
pages of the generated PDF back to PNGs for comparison. The pdf.js
process itself runs in the browser, so there's quite a lot of
back-and-forth traffic involved; this approach is not fast. But we're
unlikely to get too many print reftests, so it's a useful baseline.

https://github.com/web-platform-tests/rfcs/pull/41

--
Add print reftest infrastructure test

--
Support print reftests in Chrome

This uses the underlying CDP command directly since PDF generation
isn't yet supported in Chrome. It also requires the browser to run in
headless mode since PDF generation is only supported in this mode.

--
Move wdspec detection higher in the order of precedence

This is primarilly so that print.py doesn't show up as a print reftest, but
also because wdspec tests are pretty easy to identify unambigously since they're
in a single subtree and are all python files.

--
Rename one WebDriverProtocol class as WdspecProtocol

This naming clash caused a confusing bug; really this class is only for wdspec tests.

--
Fix typo in docstring

Co-authored-by: Stephen McGruer <smcgruer@chromium.org>

--

wpt-commits: 14318a51c8bbb4f93da025d873d0cadcc352f19e, 7f8fed23452026c68eed6d2987eaef13b9a7f561, 13ec04fe7ba89fc2e532c710acb0afbcb4db3715, 96f15e060633d1c2470353acf1e23c31d85897d9, ed440d946653bfbd53eef6cd76314f548bdabeda, 51815349ffae146d3a822a1d9d72046a492709db, c8447fe1835f792d109a019523aca7cdfc6dd72d, b0e3c1ce95151503be5037c2888563f19cc5875e, 7ef00b794ca222b6e59b27997e0bc67c0398a7d6, e06c2c218f9a95d1a18cd175fddd6fe3d3a04d02
wpt-pr: 21901

Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/981315095dae [wpt PR 21901] - Add support for print reftests, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/c0200b4c04be [wpt PR 21901] - Add support for print reftests, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: