1616870 - IsRunningAsASnap incorrectly detected when not running from a snap

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Sergio Schvezov]

Attachment: snap_name.patch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

On Ubuntu

• apt install firefox
• snap install emacs --classic
• launch emacs
• from emacs, launch firefox (the deb)

Actual results:

Firefox detects it is in a snap since the SNAP environment variable was exported for the context of emacs.

Expected results:

Firefox should have a stricter check. I have attached a proposal patch.

Comment 1

[Olivier Tilloy]

FWIW the patch looks good to me and makes sense.

Comment 2

[Sergio Schvezov]

Can I have this bug assigned to myself?

Comment 3

[Johan Lorenzo [:jlorenzo]]

Hi Sergio!

Thank you very much for filing this and providing a patch! I agree with Olivier the patch looks good to me. Although, I don't feel qualified to r+ it. I'm not a Gecko developer and I haven't written C++ in years.

The Shell Integration component doesn't have an owner and when I look at who changed this file[1], nobody really stands out. I had a quick chat with Sylvestre and he said :glandium could be a good fit. How does this sound to you, Mike?

[1] https://hg.mozilla.org/mozilla-central/annotate/0cec40c582f0e90b3690dc3c9fcf8a098d49ca2d/browser/components/shell/nsGNOMEShellService.cpp?ignorews=1

Comment 4

[Mike Hommey [:glandium]]

Karl, what do you think? Or should we redirect this to the Red Hat folks?

Comment 5

[Karl Tomlinson (:karlt)]

Yes, I'm not familiar this this.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I'll look at it.
Sergio can you use phabricator to submit the patch? see https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
AFAIK Mozilla no longer commits patches from bugzilla.

Comment 7

[Sergio Schvezov]

Sounds good! I will do that tomorrow when my holiday break is over

Comment 8

[Sergio Schvezov]

Attachment: Bug 1616870 - Correctly detect when running as a snap

Comment 9

[Sergio Schvezov]

Hi Marin, I have submitted the patch to phabricator and set you up as a reviewer (hope that is what was expected, if not I will take note of this, there was a lot of reading involved).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b60ed8edab47
Correctly detect when running as a snap r=stransky

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b60ed8edab47