Closed Bug 1616912 Opened 4 years ago Closed 4 years ago

Remove unused locale related code from nsChromeRegistry.

Categories

(Core :: Internationalization, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

There are a couple places where we still expose locale related operations on ChromeRegistry that are not used or needed anymore.

Let's further clean it up.

Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e9a6ba72099
Remove unused locale related code from nsChromeRegistry. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Regressions: 1617371

Was it intentional that you removed the function completely from IDL ?

Could the function be kept, just with that parameter removed?

Thunderbird calls that function.

Flags: needinfo?(gandalf)

Hi Kai! I have no problem keeping it but can you explain why would you use it instead of LocaleService?

Flags: needinfo?(gandalf)

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #5)

I have no problem keeping it but can you explain why would you use it instead of LocaleService?

Hi! Thanks a lot for the quick reply and considering that option. However, in the meantime Magnus concluded that we probably don't need the related code any more. So we'll try to keep things as is for now. Also thanks for the pointer to the alternative LocaleService.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: