1616999 - Minor cleanups around language identifier parsing in int/locale

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

This is just a set of smaller cleanups that I noticed while fixing other bugs that would help with maintenance of the module:

1. Rename Locale::AddLikelySubtags to Locale::Maximize following ECMA402.
2. Switch LocaleService::IsLocaleRTL to use unic_langid instead of ICU.
3. Use unic_langid new_langid_for_mozilla in fluent-langneg.
4. Move the ICU include in OSPreferences to GTK specification to better express where it's needed.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1616999 - Rename MozLocale::AddLikelySubtags to Maximize following ECMA402 Intl.Locale convention.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1616999 - Move LocaleService::IsLocaleRTL to use unic_langid.

Depends on D63561

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1616999 - Use unic-langid-ffi new_langid_for_mozilla in fluent-langneg.

Depends on D63562

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1616999 - Move the ICU include to GTK OSPreferences.

Depends on D63563

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d67220ef9a91
Rename MozLocale::AddLikelySubtags to Maximize following ECMA402 Intl.Locale convention. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/8a875e45bcf1
Move LocaleService::IsLocaleRTL to use unic_langid. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/c5a54dd0284e
Use unic-langid-ffi new_langid_for_mozilla in fluent-langneg. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/908b192e5bd6
Move the ICU include to GTK OSPreferences. r=jfkthame

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d67220ef9a91
https://hg.mozilla.org/mozilla-central/rev/8a875e45bcf1
https://hg.mozilla.org/mozilla-central/rev/c5a54dd0284e
https://hg.mozilla.org/mozilla-central/rev/908b192e5bd6