1617023 - Implement Gamepad for XRInputSource

Status: RESOLVED FIXED

(Core :: WebVR, task)

Description

[Daosheng Mu[:daoshengmu]]

We need to do some additional works in Gamepad module for motion controllers that are specific for XR devices.

• Check controller button/axis mapping if they match to WebXR input profiles properly.
• Make sure gamepad instance is not added to navigator when webxr is enabled.
• Gamepad id attribute must be "".
• Gamepad index attribute must be -1.
• Gamepad connected attribute must be true until its XRInputSource is removed or the XRSession is ended.
• If an axis reported by the gamepad's axes array represents an axis of a touchpad, the value MUST be 0 when the associated GamepadButton's touched is false.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Testing phabricator pushing.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 1: Integrating Gamepad with XRInputSource.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 2: Adjusting OpenVR/Oculus btn mapping according to WebXR spec.

Depends on D64264

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 3: Implement XR controller selection and squeeze actions.

Depends on D64265

Comment 5

[Daosheng Mu[:daoshengmu]]

TargetRaySpace, GripSpace, and controller states in XRInputSource work properly now. I just have more thing to fix regarding to the orientation of XRSpace.

Comment 6

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #5)

TargetRaySpace, GripSpace, and controller states in XRInputSource work properly now. I just have more thing to fix regarding to the orientation of XRSpace.

I have confirmed OpenVR and Oculus controllers work as my expectation, and they are ready to review.

Comment 7

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 1: Integrating Gamepad with XRInputSource.

MozReview-Commit-ID: 9gHLqyYqjnE

Comment 8

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 2: OpenVR/Oculus controller XR mode.

MozReview-Commit-ID: 1tQEuvkwbtQ

Depends on D67431

Comment 9

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 3: Implement XR controller selection and squeeze actions.

MozReview-Commit-ID: KGAUnnlivzz

Depends on D67432

Comment 10

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1617023 - Part 2: OpenVR/Oculus controller XR mode.

https://phabricator.services.mozilla.com/D67432

Depends on D67431

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ebf382e7133
Part 1: Integrating Gamepad with XRInputSource. r=kip
https://hg.mozilla.org/integration/autoland/rev/f54ac49bbc0a
Part 2: OpenVR/Oculus controller XR mode. r=kip
https://hg.mozilla.org/integration/autoland/rev/546b90fd1689
Part 3: Implement XR controller selection and squeeze actions. r=kip

Comment 12

[Razvan Maries]

Backed out for build bustages.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1611310#c9.

Backout: https://hg.mozilla.org/integration/autoland/rev/c125833dc46abea4b53adc37022b71a5cd10a11c

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a6247b39244
Part 1: Integrating Gamepad with XRInputSource. r=kip
https://hg.mozilla.org/integration/autoland/rev/8cadc6705690
Part 2: OpenVR/Oculus controller XR mode. r=kip
https://hg.mozilla.org/integration/autoland/rev/2ff0eabe84e9
Part 3: Implement XR controller selection and squeeze actions. r=kip

Comment 14

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1617023) for causing mass bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=71de2075e13ea98ed94f80788a6003980b1a1a3d&selectedJob=296724638

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296724638&repo=autoland&lineNumber=37338

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51179c777996
Backed out 3 changesets for causing mass bustages CLOSED TREE

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c3dd4a36d5
Part 1: Integrating Gamepad with XRInputSource. r=kip
https://hg.mozilla.org/integration/autoland/rev/a98e10887bc0
Part 2: OpenVR/Oculus controller XR mode. r=kip
https://hg.mozilla.org/integration/autoland/rev/8fb585fedcbb
Part 3: Implement XR controller selection and squeeze actions. r=kip

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/67c3dd4a36d5
https://hg.mozilla.org/mozilla-central/rev/a98e10887bc0
https://hg.mozilla.org/mozilla-central/rev/8fb585fedcbb