1617036 - Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe

Status: RESOLVED FIXED

(Core :: Networking, task, P1)

Comment 1

[Michal Novotny [:michal]]

Attachment: Bug 1617036 - Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ac1f7241ee
Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe r=dragana

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for android bustages on nsAndroidNetworkLinkService.cpp.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=39ac1f7241ee222e0b332eb8e88534a39e564756&selectedJob=290192283

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=290192283&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/37fdefb99f1c84be95513bfd05e859a068f041f9

[task 2020-02-24T14:28:50.847Z] 14:28:50     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/system/android'
[task 2020-02-24T14:28:50.851Z] 14:28:50     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 --target=arm-linux-androideabi -o nsAndroidNetworkLinkService.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/system/android -I/builds/worker/workspace/build/src/obj-firefox/netwerk/system/android -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/arm-linux-androideabi -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -mno-unaligned-access -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/nsAndroidNetworkLinkService.o.pp   /builds/worker/workspace/build/src/netwerk/system/android/nsAndroidNetworkLinkService.cpp
[task 2020-02-24T14:28:50.852Z] 14:28:50    ERROR -  /builds/worker/workspace/build/src/netwerk/system/android/nsAndroidNetworkLinkService.cpp:165:31: error: no member named 'NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS' in namespace 'mozilla::Telemetry'
[task 2020-02-24T14:28:50.852Z] 14:28:50     INFO -            mozilla::Telemetry::NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS,
[task 2020-02-24T14:28:50.852Z] 14:28:50     INFO -            ~~~~~~~~~~~~~~~~~~~~^
[task 2020-02-24T14:28:50.852Z] 14:28:50     INFO -  1 error generated.
[task 2020-02-24T14:28:50.852Z] 14:28:50     INFO -  /builds/worker/workspace/build/src/config/rules.mk:731: recipe for target 'nsAndroidNetworkLinkService.o' failed
[task 2020-02-24T14:28:50.853Z] 14:28:50    ERROR -  make[4]: *** [nsAndroidNetworkLinkService.o] Error 1
[task 2020-02-24T14:28:50.853Z] 14:28:50     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/system/android'
[task 2020-02-24T14:28:50.853Z] 14:28:50     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'netwerk/system/android/target-objects' failed
[task 2020-02-24T14:28:50.853Z] 14:28:50    ERROR -  make[3]: *** [netwerk/system/android/target-objects] Error 2
[task 2020-02-24T14:28:50.853Z] 14:28:50     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2020-02-24T14:28:50.867Z] 14:28:50     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2020-02-24T14:28:50.868Z] 14:28:50     INFO -  netwerk/protocol/http/Unified_cpp_protocol_http3.o

Comment 4

[Michal Novotny [:michal]]

I forgot to remove the probe from Android code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31fabee18f94
Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe r=dragana

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/31fabee18f94

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ac1f7241ee
Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe r=dragana

== Change summary for alert #25264 (as of Sat, 07 Mar 2020 17:51:11 GMT) ==

Regressions:

38% raptor-tp6m-espn-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 pgo 2,291.32 -> 3,167.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25264

Comment 8

[Michal Novotny [:michal]]

(In reply to Alexandru Ionescu :alexandrui (needinfo me) from comment #7)

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ac1f7241ee
Remove NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS probe r=dragana

== Change summary for alert #25264 (as of Sat, 07 Mar 2020 17:51:11 GMT) ==

Regressions:

38% raptor-tp6m-espn-geckoview-cold loadtime android-hw-p2-8-0-android-aarch64 pgo 2,291.32 -> 3,167.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25264

This doesn't make much sense. We just removed some code. Even if it really causes the regression for whatever reason, we cannot do much with it.

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Michal Novotny [:michal] from comment #8)

This doesn't make much sense. We just removed some code. Even if it really causes the regression for whatever reason, we cannot do much with it.

Indeed, looks like it was a spike and then came back.