1617133 - Break down "sync_error" into more detailed uptake statuses

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement, P2)

Description

[Mathieu Leplatre [:leplatrem]]

In the current code, sync_error is the fallback status on synchronization errors.

It could mean that the synchronization failed for a completely unknown reason, or that we don't categorize errors properly (eg. obscure IndexedDB errors). And this lack of details makes it hard to investigate and act.

Using Telemetry, we can break down sync_error by version, or by collection, but so far none of those popped out clearly.

We should find a way to break down these sync errors properly.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Sync errors by version

Comment 2

[Mathieu Leplatre [:leplatrem]]

Attachment: Breakdown by collection on Firefox 73

Comment 3

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1617133 - Improve categorization of Remote Settings errors

Comment 4

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1617133 - Reduce complexity of RemoteSettingsClient.maybeSync()

Depends on D64402

Comment 5

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1617133 - Report error names to Telemetry on Nightly

Depends on D64559

Comment 6

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1617133 - Upgrade kinto-offline-client to v13.0.0

Depends on D64560

Comment 7

[Mathieu Leplatre [:leplatrem]]

Depends on https://github.com/Kinto/kinto.js/pull/1205

Comment 8

[Mathieu Leplatre [:leplatrem]]

Attachment: data-review.txt

Comment 9

[Chris H-C :chutten]

Comment on attachment 9129802 [details]
data-review.txt

Q5 should include a list of the measurements being added. In this case it would name and describe `uptake.remotecontent.result.uptake.{remotesettings|normandy}`'s extra key `errorName`. Specific information that's important is if this has a limited possible list of values or if the string could be anything at all.

Q6 requires that an individual be named as responsible for this collection if it is to be a permanent collection. In cases of expanded collection it's usually the same person responsible for the rest of the collection.

Q8 requires a response. (In this case I believe Firefox's Data Choices setting controls it as it's Telemetry)

Comment 10

[Mathieu Leplatre [:leplatrem]]

Attachment: data-review.txt

Comment 11

[Chris H-C :chutten]

Comment on attachment 9130189 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :lepatrem is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for Nightly only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e68faf86cde
Improve categorization of Remote Settings errors r=glasserc
https://hg.mozilla.org/integration/autoland/rev/ca58b81ab8bf
Reduce complexity of RemoteSettingsClient.maybeSync() r=glasserc
https://hg.mozilla.org/integration/autoland/rev/2b2a9e7fafb0
Report error names to Telemetry on Nightly r=glasserc
https://hg.mozilla.org/integration/autoland/rev/c5b4e728621b
Upgrade kinto-offline-client to v13.0.0 r=glasserc

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8e68faf86cde
https://hg.mozilla.org/mozilla-central/rev/ca58b81ab8bf
https://hg.mozilla.org/mozilla-central/rev/2b2a9e7fafb0
https://hg.mozilla.org/mozilla-central/rev/c5b4e728621b

Comment 14

[Mathieu Leplatre [:leplatrem]]

The error names are coming in: https://sql.telemetry.mozilla.org/queries/68824/

So far, very few data, but IndexedDB UnknownError and AbortError ...

Once we have more data, I'll talk to Storage folks on Riot https://matrix.to/#/!xtNTVvhlaSRcvfrhfT:mozilla.org?via=mozilla.org