1617147 - Windows builds fail without makensis available

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Mike Hommey [:glandium]]

They fail because a bunch of places do some ifdef MAKENSISU, but MAKENSISU is actually set to : when makensis is not found (idiosyncrasy from check_prog())

Comment 1

[Mike Hommey [:glandium]]

Also, there's a missing ifdef HAVE_MAKENSISU for maintenanceservice_installer.exe in browser/installer/package-manifest.in

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1617147 - Stop setting check_prog result to : for missing programs. r=#build!

This was cargo culted from the autoconf equivalent, and while it makes a
command that does "$(PROG) foo" work because it becomes ": foo", that
may or may not actually be a desirable outcome.

OTOH, we do have some places where there are some "ifdef PROG" that are
just plain wrong when PROG is always actually set.

One place I do know that does check if the value is not ":" is for
OBJCOPY, which is still set from autoconf.

All in all, looking at all the check_prog(allow_missing=True) we have in
python configure, it doesn't seem anything is checking for ":", and that
doesn't seem like the right status quo.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5069c471cc9
Stop setting check_prog result to : for missing programs. r=nalexander,rstewart

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b5069c471cc9