1617156 - Store snapped reference frame offset in prim rect to minimize quantization effects

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We currently pass in the snapped reference frame relative offset in the integer parameters of the prim header to the shader. We don't actually use the prim rect size for anything, so we could just stuff that offset there and avoid any quantization effects caused by us casting the float to an integer.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1617156 - Store snapped reference frame offset in prim rect for text to avoid quantization effects.

Currently we quantize the snapped reference frame relative offset used
in the shader in order to stuff it in our extra integer parameter fields
in the prim header. Since we don't use the prim rect size for anything
in the text shader, this patch just puts it there instead, and avoids
quantizing that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26d8dfb033ce
Store snapped reference frame offset in prim rect for text to avoid quantization effects. r=lsalzman

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/26d8dfb033ce