1617181 - Assert .this is the only internal dot-name which end up in with-environments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[André Bargull [:anba]]

IsUnscopableDotName also checks for .generator, even though BytecodeEmitter::emitAtomOp already asserts .generator is never looked up through JSOp::GetName or JSOp::GetGName.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1617181: Assert dotThis is the only dot-name visible in with-environments. r=mgaudet!

BytecodeEmitter::emitAtomOp() already asserts .generator won't be retrieved
via JSOp::Get[G]Name. And the class fields dot-names can't occur in
with-environments, because classes are implicitly strict mode and
with-statements aren't allowed in strict mode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b377b122faf
Assert dotThis is the only dot-name visible in with-environments. r=mgaudet

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8b377b122faf