Closed Bug 1617205 Opened 4 years ago Closed 4 years ago

When initializing the permission manager, we spend too much time getting the origin out of the principal which we just created out of the origin

Categories

(Core :: Permission Manager, enhancement)

Product:
Core
Component:
Permission Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(2 files)

perf profile
168.96 KB, image/png
Details
Bug 1617205 - In nsPermissionManager::AddInternal(), only compute the origin string when it is needed, and when the caller doesn't have it available;
47 bytes, text/x-phabricator-request
Details | Review
Attached image perf profile —

When initializing the permission manager, we read origins as strings, create principals out of them and then try to get the origin string out of the principals again. This is wasteful. It takes about 10% of a startup profile (see the perf profile in the screenshot).

Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a7cb2d7412d
In nsPermissionManager::AddInternal(), only compute the origin string when it is needed, and when the caller doesn't have it available; r=baku

https://hg.mozilla.org/mozilla-central/rev/2a7cb2d7412d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: