Closed
Bug 161722
Opened 23 years ago
Closed 23 years ago
nsFilePicker.js has unreachable code (try block)
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(2 files)
|
1.95 KB,
patch
|
timeless
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
|
729 bytes,
patch
|
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
i was cleaning other stuff out and ran across this
|
||
Comment 2•23 years ago
|
||
Comment on attachment 94483 [details] [diff] [review]
remove outer try block
xpconnect hates me sometimes too :)
r=db48x
Attachment #94483 -
Flags: review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 94483 [details] [diff] [review]
remove outer try block
seems reasonable...
Attachment #94483 -
Flags: review+ → superreview+
|
|
||
Comment 4•23 years ago
|
||
er, and sr=bzbarsky.
Attachment #94483 -
Flags: review+
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 6•23 years ago
|
||
This bug seems to have caused regression bug 161722.
I suggest to back this patch out.
Reopening for backout.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 7•23 years ago
|
||
The correct regression bug number is bug 161934.
Comment on attachment 95080 [details] [diff] [review]
undo the order change of typeof
r=kaie on irc
Attachment #95080 -
Flags: review+
|
|
||
Comment 10•23 years ago
|
||
Comment on attachment 95080 [details] [diff] [review]
undo the order change of typeof
sr=bzbarsky. Seems much more reasonable. ;)
Attachment #95080 -
Flags: review+ → superreview+
|
Assignee | |
Comment 11•23 years ago
|
||
checked in, sorry about that.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•