1617324 - non-e10s busted in GeckoView

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect)

Description

[Randall Barker [:rbarker]]

I was able to reproduce in tip of central and reproduces in FxR using GV Nightly 75.0.20200221095110

If e10s is disabled in GVE, it is no longer able to load URL. It just spews the following on repeat:

02-21 16:45:21.982 13730 13769 D GeckoViewWebBrowserChrome[C]: shouldLoadURI http://google.com/
02-21 16:45:21.983 13730 13769 D GeckoViewBrowserTabParent: receiveMessage: Browser:LoadURI {"data":{"loadOptions":{"uri":"http://google.com/","flags":0,"referrerInfo":"BBoSnxDOS9qmDeAnom1e0AAAAAAAAAAAwAAAAAAAAEYAAAAAAAEAAQA=","triggeringPrincipal":"eyIwIjp7IjAiOiJtb3otbnVsbHByaW5jaXBhbDp7ZGYyMjkwMzEtZGIwNy00NzhkLTk1OWUtOTI5NTk4NmE0NDA5fSJ9fQ==","csp":null,"reloadInFreshProcess":false},"historyIndex":-1},"json":{"loadOptions":{"uri":"http://google.com/","flags":0,"referrerInfo":"BBoSnxDOS9qmDeAnom1e0AAAAAAAAAAAwAAAAAAAAEYAAAAAAAEAAQA=","triggeringPrincipal":"eyIwIjp7IjAiOiJtb3otbnVsbHByaW5jaXBhbDp7ZGYyMjkwMzEtZGIwNy00NzhkLTk1OWUtOTI5NTk4NmE0NDA5fSJ9fQ==","csp":null,"reloadInFreshProcess":false},"historyIndex":-1},"name":"Browser:LoadURI","objects":{},"principal":null,"sync":false,"target":{}}
02-21 16:45:21.983 13730 13769 D GeckoViewXUL: updateRemoteAndNavigate: uri=http://google.com/ currentType=null remoteType=null
02-21 16:45:21.985 13730 13769 D GeckoViewModule: unregisterListener
02-21 16:45:21.985 13730 13769 D GeckoViewNavigation: onDisable
02-21 16:45:21.986 13730 13769 D GeckoViewProcessHangMonitor: onDisable
02-21 16:45:21.986 13730 13769 D GeckoViewModule: unregisterListener
02-21 16:45:21.986 13730 13769 D GeckoViewProgress: onDisable
02-21 16:45:21.986 13730 13769 D GeckoViewModule: unregisterListener
02-21 16:45:21.986 13730 13769 D GeckoViewModule: unregisterListener
02-21 16:45:21.988 13730 13769 D GeckoViewMedia[C]: handleEvent: pagehide
02-21 16:45:21.988 13730 13769 D GeckoViewSelectionAction[C]: handleEvent: visibilitychange
02-21 16:45:21.988 13730 13769 D GeckoViewAutofill[C]: handleEvent: pagehide
02-21 16:45:21.988 13730 13769 D GeckoViewAutofill: Clearing auto-fill
02-21 16:45:21.991 13730 13769 D GeckoViewModule: enableQueuing true
02-21 16:45:21.995 13730 13769 D GeckoViewContent[C]: onInit
02-21 16:45:21.996 13730 13769 D GeckoViewModule: enableQueuing true
02-21 16:45:21.997 13730 13769 D GeckoViewSettings[C]: onInit
02-21 16:45:21.999 13730 13769 D GeckoViewAutofill[C]: onInit
02-21 16:45:21.999 13730 13769 D GeckoViewModule: enableQueuing true
02-21 16:45:21.999 13730 13769 D GeckoViewModule: registerListener ["GeckoView:MediaObserve","GeckoView:MediaUnobserve","GeckoView:MediaPlay","GeckoView:MediaPause","GeckoView:MediaSeek","GeckoView:MediaSetVolume","GeckoView:MediaSetMuted","GeckoView:MediaSetPlaybackRate"]
02-21 16:45:22.000 13730 13769 D GeckoViewNavigation: onEnable
02-21 16:45:22.000 13730 13769 D GeckoViewProcessHangMonitor: onEnable
02-21 16:45:22.000 13730 13769 D GeckoViewModule: registerListener ["GeckoView:HangReportStop","GeckoView:HangReportWait"]
02-21 16:45:22.000 13730 13769 D GeckoViewModule: enableQueuing true
02-21 16:45:22.000 13730 13769 D GeckoViewProgress[C]: onInit
02-21 16:45:22.001 13730 13769 D GeckoViewProgress: onEnable
02-21 16:45:22.001 13730 13769 D GeckoViewModule: registerListener GeckoView:FlushSessionState
02-21 16:45:22.001 13730 13769 D GeckoViewProgress: onSettingsUpdate: {"chromeUri":null,"screenId":0,"userAgentOverride":null,"allowJavascript":true,"userAgentMode":0,"viewportMode":0,"useTrackingProtection":false,"suspendMediaWhenInactive":false,"usePrivateMode":false,"unsafeSessionContextId":null,"displayMode":0,"sessionContextId":null,"fullAccessibilityTree":false,"isPopup":false}
02-21 16:45:22.001 13730 13769 D GeckoViewModule: registerListener ["ContentBlocking:RequestLog"]
02-21 16:45:22.010 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewContent"}
02-21 16:45:22.011 13730 13769 D GeckoViewModule: enableQueuing false
02-21 16:45:22.011 13730 13769 D GeckoViewModule: dispatchQueued
02-21 16:45:22.011 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewContent"}
02-21 16:45:22.011 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewSettings"}
02-21 16:45:22.011 13730 13769 D GeckoViewModule: enableQueuing false
02-21 16:45:22.011 13730 13769 D GeckoViewModule: dispatchQueued
02-21 16:45:22.011 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewSettings"}
02-21 16:45:22.011 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"SessionStateAggregator"}
02-21 16:45:22.011 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"SessionStateAggregator"}
02-21 16:45:22.011 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewAutofill"}
02-21 16:45:22.012 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewAutofill"}
02-21 16:45:22.012 13730 13769 D GeckoViewContent[C]: onEnable
02-21 16:45:22.012 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewMedia"}
02-21 16:45:22.012 13730 13769 D GeckoViewModule: enableQueuing false
02-21 16:45:22.012 13730 13769 D GeckoViewModule: dispatchQueued
02-21 16:45:22.012 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewMedia"}
02-21 16:45:22.012 13730 13769 D GeckoViewMedia[C]: onEnable
02-21 16:45:22.013 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewProgress"}
02-21 16:45:22.013 13730 13769 D GeckoViewModule: enableQueuing false
02-21 16:45:22.013 13730 13769 D GeckoViewModule: dispatchQueued
02-21 16:45:22.013 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewProgress"}
02-21 16:45:22.014 13730 13730 D GeckoSession: handleMessage GeckoView:PageStart uri=about:blank
02-21 16:45:22.014 13730 13730 I GeckoViewActivity: Starting to load page at about:blank
02-21 16:45:22.014 13730 13769 D GeckoViewXUL: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewSelectionAction"}
02-21 16:45:22.014 13730 13769 D GeckoViewProgress: receiveMessage GeckoView:ContentModuleLoaded {"module":"GeckoViewSelectionAction"}
02-21 16:45:22.014 13730 13730 I GeckoViewActivity: zerdatime 1629501 - page load start
02-21 16:45:22.015 13730 13769 D GeckoViewSelectionAction[C]: onEnable
02-21 16:45:22.015 13730 13730 D GeckoSession: handleMessage GeckoView:LocationChange uri=about:blank
02-21 16:45:22.015 13730 13769 D GeckoViewContent[C]: receiveMessage: GeckoView:RestoreState

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Ah sorry about that, that's from Bug 1613237. I'll attach a patch.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1617324 - Always return true in non-e10s mode for shoudlLoadURI.

In Bug 1617324 we started receiving calls for in-process windows for
WebBrowserChrome, which means we now have to handle the non-e10s case too. In
non-e10s there's only one process, so shouldLoadURI should always return true.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5952facc6f96
Always return true in non-e10s mode for shoudlLoadURI. r=aklotz

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5952facc6f96

Comment 5

[Chris Peterson [:cpeterson]]

Moving some e10s bugs to the new GeckoView::Sandboxing component.