1617389 - When generating compile_commands.json, insert -ferror-limit before the file name

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

In bug 1612657 I changed the code that generates compile_commands.json to add a clang argument to the "command" field. I did that by appending to the array of existing arguments. Unfortunately doing that meant that the name of the source file is no longer the last thing in the "command" field, and so is now more difficult to spot. We should move the argument that I added to come before the file name to avoid this.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1617389. When generating compile_commands.json, insert -ferror-limit before the file name. r=botond

This makes it easier to see the name of the file in the "command" field.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d0a897c9219
When generating compile_commands.json, insert -ferror-limit before the file name. r=botond

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0d0a897c9219