1617419 - Feature recommendation shown even if disabled in settings

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Felix]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

I surfed on youtube.com, nothing out of the ordinary, I reloaded the youtube homepage a few times, and on the second or third time, a feature recommendation message appeared in the address bar. This message persisted over mutiple page reloads.

I have not been able to reproduce this in another browser session, but AFAIK the recommendation message also only appears sporadically even if enabled.

I do have both "Recommend extensions as you browse" and "Recommend features as you browse" options unchecked aka. disabled in the "General" -> "Browsing" preferences page.
(Screenshot: https://i.imgur.com/EtKkzXo.png)

Browser version info:
Name Firefox
Version 73.0.1
Build-ID 20200217142647
User-Agent Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

System info:
OS: Ubuntu 18.04.4 LTS, x64
Packages:
firefox (amd64); Version "73.0.1+build1-0ubuntu0.18.04.1"
firefox-locale-de (amd64); Version "73.0.1+build1-0ubuntu0.18.04.1"

Actual results:

Firefox showed me a feature recommendation notification in the address bar for the feature "pinned tabs".

(See screenshot here: https://i.imgur.com/D8nknDR.png)

Expected results:

Firefox should not have shown this notification and respected the preferences ("Recommend extensions as you browse" and "Recommend features as you browse").

Comment 1

[Gingerbread Man]

(In reply to Felix from comment #0)

https://i.imgur.com/D8nknDR.png

Pontoon translation verifies this is coming from the recommendation feature.

Comment 2

[Andrei Oprea [:andreio]]

Fixed in https://github.com/mozilla/messaging-system-inflight-assets/pull/7

Comment 3

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (75.0a1 Build ID - 20200305212712) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, the "Pin Tab" recommendation is no longer displayed if the "Recommend features as you browse" option is unchecked in the "about:preferences" page.

Comment 4

[marcin.rambo.roguski]

And it's back: today Firefox 82.0 recommended password manager to me ("never loose a password again"), even though recommendations are disabled.