1617472 - Remove CSS keyword tables and such.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Minor cleanup of image layers. r=#style

Remove some unused enums and some single-call function that also caused a copy
of two LengthPercentage values.

This is pretty drive-by, could be a different bug.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Remove kFontSmoothingKTable. r=#style

Use the more general mechanism to get a property value. We can't just remove
the getter because of the resist-fingerprinting check, but...

Depends on D63791

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Use enums for text-align / text-align-last. r=#style,jfkthame

This also fixes some backwards logic in nsBlockFrame::ReflowDirtyLines, and adds
some static assertions to nsGenericHTMLElement that almost cause a very subtle
bug.

Depends on D63792

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Remove kTextAlignKTable. r=#style

Depends on D63793

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Remove kTextDecorationStyleKTable. r=#style

In a somewhat easy way. There are better ways to do this (moving
text-decoration-style to be a proper cbindgen enum class or such), but this
does the job for now.

Depends on D63794

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Remove nsCSSKeywords and related infrastructure. r=#style

Seeya

Depends on D63795

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Minor cleanup of image layers. r=#style

Remove some unused enums and some single-call function that also caused a copy
of two LengthPercentage values.

This is pretty drive-by, could be a different bug.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Remove kFontSmoothingKTable. r=#style

Use the more general mechanism to get a property value. We can't just remove
the getter because of the resist-fingerprinting check, but...

Depends on D63797

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617472 - Put Servo_GetPropertyValue behind a method in ComputedStyle. r=heycam

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f817fa67b51f
Minor cleanup of image layers. r=heycam
https://hg.mozilla.org/integration/autoland/rev/17061d1394b7
Remove kFontSmoothingKTable. r=heycam
https://hg.mozilla.org/integration/autoland/rev/400b7003dd40
Use enums for text-align / text-align-last. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3d90d2bf476b
Remove kTextAlignKTable. r=heycam
https://hg.mozilla.org/integration/autoland/rev/ad22c10d9fbe
Remove kTextDecorationStyleKTable. r=heycam
https://hg.mozilla.org/integration/autoland/rev/2827d9d7168e
Remove nsCSSKeywords and related infrastructure. r=heycam

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f817fa67b51f
https://hg.mozilla.org/mozilla-central/rev/17061d1394b7
https://hg.mozilla.org/mozilla-central/rev/400b7003dd40
https://hg.mozilla.org/mozilla-central/rev/3d90d2bf476b
https://hg.mozilla.org/mozilla-central/rev/ad22c10d9fbe
https://hg.mozilla.org/mozilla-central/rev/2827d9d7168e

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ab6bc11f5a9
Put Servo_GetPropertyValue behind a method in ComputedStyle. r=heycam

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8ab6bc11f5a9