1617532 - Replace typedef by using

Status: NEW

(Developer Infrastructure :: Source Code Analysis, task, P4)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1617528 +++

typedef are less readable than using

for example

  typedef void (*NativeIntersectionObserverCallback)(
      const Sequence<OwningNonNull<DOMIntersectionObserverEntry>>& aEntries);

becomes

  using NativeIntersectionObserverCallback =
      void (*)(const Sequence<OwningNonNull<DOMIntersectionObserverEntry>>&);

Running the autofix on js/

./mach static-analysis check --checks="-*, modernize-use-using" --fix  js

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug 1617532 - js/ replace typedef by using r?jandem,jwalden

Done with:
./mach static-analysis check --checks="-*, modernize-use-using" --fix js/

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f449a588de9a
js/ replace typedef by using r=jandem

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f449a588de9a

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Sylvestre, maybe it's time to close this bug?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Andi, do you think we should finish this ? (as good first bugs)
or just close it?

Comment 6

[Andi [:andi]]

Let's finish it as a good first bug, it would be wise from us to get rid of as much legacy code as possible.

Comment 7

[Garima Mazumdar]

Hi! I'm Garima, an Outreachy participant, and would like to work on this bug :)

Comment 8

[Andi [:andi]]

Hello Garima, please assign this bug t yourself and you can submit patches.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:andi, maybe it's time to close this bug?

Comment 10

[Timur Valeev]

Hi. I want to finish this bug. As I can see that @Sylvestre completed the replacement for js part. Am I right that is needed to replace typedef to using for other parts of the source code? By the way how to assign it to myself?

Comment 11

[Timur Valeev]

Forget to add needinfo :)

Comment 12

[Sylvestre Ledru [:Sylvestre]]

yeah, doing it for a whole code base (and js too as it might have regressed). I tried a few days ago and it might requires some manual fixes too.

It will be assigned at your first patch.

Comment 13

[Timur Valeev]

Attachment: WIP: Bug 1617532 - replace typedef by using

Comment 14

[Timur Valeev]

Hi Sylvestre! I started to change source code and have a question.
Firstly I ran ./mach static-analysis check --checks="-*, modernize-use-using" --fix js/ and only one file was fixed:
js/xpconnect/loader/AutoMemMap.h
But as I can see from rgrep output other files in js/ also has similar code. Just for example:
https://searchfox.org/mozilla-central/source/js/public/CharacterEncoding.h#31
typedef mozilla::Range<Latin1Char> Base;
So is it needed to fix them manually?

Comment 15

[Sylvestre Ledru [:Sylvestre]]

the goal of this bug is to fix everything on the tree (probably directory by directory)
js/ is what we started with

don't bother about manual changes, leave them as it for now

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.