Closed Bug 1617566 Opened 5 years ago Closed 5 years ago

Make `upload` alias for `submit`

Categories

(Conduit :: moz-phab, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evilpies, Assigned: glob)

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

Apparently other browser use upload instead of submit.

Frédéric on Matrix:

Chromium: "git cl upload"
WebKit: "webkit-patch upload"
Gecko: "moz-phab [submit]" 🥴

I couldn't figure out how to run moz-phab locally from the repo, but I think we just need to add aliases=['upload'] to add_parser here.

Type: defect → enhancement

Why do you think unification is needed here?

It's nice for people working on multiple engines

Assignee: nobody → glob
Keywords: conduit-triaged
Priority: -- → P2

For parity with other browser submission tools.

I couldn't figure out how to run moz-phab locally from the repo

If you aren't familiar with developing with pip-delivered cli tools this isn't immediately obvious.

From the Development section of the readme: To install your code call pip3 install -e . from MozPhab project directory. Your code will be executed by calling moz-phab-dev.

I usually create a venv for development, and run that venv's pip3, so the resulting moz-phab-dev script ends up in the venv's bin/ directory instead of in my system's env.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: