Make `upload` alias for `submit`
Categories
(Conduit :: moz-phab, enhancement, P2)
Tracking
(Not tracked)
People
(Reporter: evilpies, Assigned: glob)
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
Apparently other browser use upload
instead of submit
.
Frédéric on Matrix:
Chromium: "git cl upload"
WebKit: "webkit-patch upload"
Gecko: "moz-phab [submit]" 🥴
I couldn't figure out how to run moz-phab locally from the repo, but I think we just need to add aliases=['upload']
to add_parser
here.
Comment 1•5 years ago
|
||
Why do you think unification is needed here?
Comment 2•5 years ago
|
||
It's nice for people working on multiple engines
I couldn't figure out how to run moz-phab locally from the repo
If you aren't familiar with developing with pip-delivered cli tools this isn't immediately obvious.
From the Development section of the readme: To install your code call pip3 install -e .
from MozPhab project directory. Your code will be executed by calling moz-phab-dev
.
I usually create a venv for development, and run that venv's pip3
, so the resulting moz-phab-dev
script ends up in the venv's bin/ directory instead of in my system's env.
Description
•