1617586 - ToInteger normalizes -0 to +0

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Yulia Startsev [:yulia]]

As discussed in: (https://github.com/tc39/ecma262/pull/1827

change ToInteger(-0) to return +0 instead of -0, because in all but one case, the result of ToInteger(-0) is either explicitly or implicitly changed from -0 to +0 anyway.

André -- if this is already done, please feel free to close this.

Comment 1

[André Bargull [:anba]]

This isn't yet (completely) done. I already have a patch, but didn't yet found the time to request review for it.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1617586 - Part 1: Don't return -0 from ToInteger. r=jwalden!

Changes ToInteger to return +0 instead of -0 and updates two callers which were
already performing the -0 to +0 conversion. Also changes NumberIsInt32 to
NumberEqualsInt32 in atomics_isLockFree, because we no longer need to care
about handling -0 in this function.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1617586 - Part 2: Rename ToIntegerPositiveZero to ToInteger. r=jwalden!

More or less undo bug 1383436 - part 4, now that ToInteger matches
ToIntegerPositiveZero.

Depends on D64027

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1617586 - Part 3: Use trunc instead of branching to use either floor or ceil. r=jwalden!

Use C++11's trunc() function instead of manually branching for negative values.

Depends on D64028

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43a19073c67f
Part 1: Don't return -0 from ToInteger. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/251650c4e157
Part 2: Rename ToIntegerPositiveZero to ToInteger. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/bd1e456b48ac
Part 3: Use trunc instead of branching to use either floor or ceil. r=jwalden

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/43a19073c67f
https://hg.mozilla.org/mozilla-central/rev/251650c4e157
https://hg.mozilla.org/mozilla-central/rev/bd1e456b48ac