1617600 - Prototype focus-visible behind a flag.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This will allow to tweak the heuristics.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617600 - Prototype :focus-visible behind a flag. r=smaug

The heuristic is that we show focus outlines for unknown or key focus, and not
for mouse / touch.

This is probably not the final heuristic we take, but this allows people to play
with it and file bugs.

Once this is mature enough we should remove :-moz-focusring in favor of
:focus-visible.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1617600 - Remove no-longer-used argument to pseudo-class-list-macro. r=jwatt

This used to be needed for Gecko interop, but now all this is in the Rust side
so we no longer need it.

Depends on D63861

Comment 3

[Sebastian Zartner [:sebo]]

I'm setting dev-doc-needed in order to get it documented on https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features once the patch landed.

Sebastian

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45464d926bf0
Prototype :focus-visible behind a flag. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b722714830cd
Remove no-longer-used argument to pseudo-class-list-macro. r=firefox-style-system-reviewers,jwatt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73d1a5e10337
Update test expectations for a test that was somehow passing on windows before implementing the pseudo-class (?).

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1617600) for causing wpt failures in focus-visible-009.html CLOSED TREE

Range of failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=bb4ff187fbece788fb3bfec7e8ab79e9e264c960&searchStr=wpt2&tochange=fd27c0bf2c4aa0ad2357e0e50a085e8f416b588a&selectedJob=290451097

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290446636&repo=autoland&lineNumber=2515

Backout: https://hg.mozilla.org/integration/autoland/rev/376f4b1d67ed85063f2b5d8030ce86084e0243fb

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Yikes: https://searchfox.org/mozilla-central/rev/96f1457323cc598a36f5701f8e67aedaf97acfcf/mobile/android/themes/geckoview/content.css#213

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccb509a148d0
Prototype :focus-visible behind a flag. r=smaug
https://hg.mozilla.org/integration/autoland/rev/85deb88b1680
Remove no-longer-used argument to pseudo-class-list-macro. r=firefox-style-system-reviewers,jwatt

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21990 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ccb509a148d0
https://hg.mozilla.org/mozilla-central/rev/85deb88b1680

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Chris Mills [:cmills]]

Note added to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#CSS - let me know if that looks OK. Thanks!